Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/BUILD.gn

Issue 1980173002: [Mac/GN] Add verify_order step for the Framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/tools/build/mac/run_verify_order.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 511
512 bundle_data("chrome_versioned_bundle_data") { 512 bundle_data("chrome_versioned_bundle_data") {
513 sources = [ 513 sources = [
514 "$root_out_dir/$chrome_framework_name.framework", 514 "$root_out_dir/$chrome_framework_name.framework",
515 "$root_out_dir/$chrome_helper_name.app", 515 "$root_out_dir/$chrome_helper_name.app",
516 ] 516 ]
517 outputs = [ 517 outputs = [
518 "{{bundle_root_dir}}/Versions/$chrome_version_full/{{source_file_part}}", 518 "{{bundle_root_dir}}/Versions/$chrome_version_full/{{source_file_part}}",
519 ] 519 ]
520 public_deps = [ 520 public_deps = [
521 ":chrome_framework",
522 ":chrome_helper_app", 521 ":chrome_helper_app",
522
523 # verify_chrome_framework_order depends on :chrome_framework and, for
524 # non-component builds, will ensure the export symbol table is correct.
525 ":verify_chrome_framework_order",
523 ] 526 ]
524 } 527 }
525 528
526 tweak_info_plist("chrome_helper_plist") { 529 tweak_info_plist("chrome_helper_plist") {
527 info_plist = "app/helper-Info.plist" 530 info_plist = "app/helper-Info.plist"
528 args = [ 531 args = [
529 "--breakpad=0", 532 "--breakpad=0",
530 "--keystone=0", 533 "--keystone=0",
531 "--scm=0", 534 "--scm=0",
532 ] 535 ]
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
749 "//build/config/sanitizers:deps", 752 "//build/config/sanitizers:deps",
750 "//chrome/app/nibs:chrome_xibs", 753 "//chrome/app/nibs:chrome_xibs",
751 ] 754 ]
752 755
753 ldflags = [ 756 ldflags = [
754 "-Wl,-install_name,@executable_path/../Versions/$chrome_version_full/$chro me_framework_name.framework/$chrome_framework_name", 757 "-Wl,-install_name,@executable_path/../Versions/$chrome_version_full/$chro me_framework_name.framework/$chrome_framework_name",
755 "-compatibility_version", 758 "-compatibility_version",
756 chrome_dylib_version, 759 chrome_dylib_version,
757 "-current_version", 760 "-current_version",
758 chrome_dylib_version, 761 chrome_dylib_version,
762 "-Wl,-order_file," + rebase_path("app/framework.order", root_build_dir),
759 ] 763 ]
760 764
761 if (is_component_build) { 765 if (is_component_build) {
762 ldflags += [ 766 ldflags += [
763 "-rpath", 767 "-rpath",
764 "@loader_path/../../../../..", 768 "@loader_path/../../../../..",
765 "-Wl,-reexport_library,libchrome_dll.dylib", 769 "-Wl,-reexport_library,libchrome_dll.dylib",
766 ] 770 ]
767 } 771 }
768 } 772 }
773
774 if (!is_asan && !is_component_build) {
775 action("verify_chrome_framework_order") {
776 script = "//chrome/tools/build/mac/run_verify_order.py"
777 stamp_file = "$target_out_dir/run_$target_name.stamp"
778 inputs = [
779 script,
780 "//chrome/tools/build/mac/verify_order",
781 ]
782 args = [
783 "--stamp",
784 rebase_path(stamp_file, root_out_dir),
785 "_ChromeMain",
786 rebase_path(
787 "$root_out_dir/$chrome_framework_name.framework/$chrome_framework_na me",
788 root_out_dir),
789 ]
790 outputs = [
791 stamp_file,
792 ]
793 public_deps = [
794 ":chrome_framework",
795 ]
796 }
797 } else {
798 group("verify_chrome_framework_order") {
799 public_deps = [
800 ":chrome_framework",
801 ]
802 }
803 }
769 } 804 }
770 805
771 # GYP version: chromium_browser_dependencies variable in chrome.gyp 806 # GYP version: chromium_browser_dependencies variable in chrome.gyp
772 group("browser_dependencies") { 807 group("browser_dependencies") {
773 public_deps = [ 808 public_deps = [
774 "//chrome/browser", 809 "//chrome/browser",
775 "//chrome/common", 810 "//chrome/common",
776 "//sync", 811 "//sync",
777 ] 812 ]
778 if (enable_plugins) { 813 if (enable_plugins) {
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
1411 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1446 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1412 "//chrome/tools/build/linux/chrome-wrapper", 1447 "//chrome/tools/build/linux/chrome-wrapper",
1413 "//third_party/xdg-utils/scripts/xdg-mime", 1448 "//third_party/xdg-utils/scripts/xdg-mime",
1414 "//third_party/xdg-utils/scripts/xdg-settings", 1449 "//third_party/xdg-utils/scripts/xdg-settings",
1415 ] 1450 ]
1416 outputs = [ 1451 outputs = [
1417 "$root_out_dir/{{source_file_part}}", 1452 "$root_out_dir/{{source_file_part}}",
1418 ] 1453 ]
1419 } 1454 }
1420 } 1455 }
OLDNEW
« no previous file with comments | « no previous file | chrome/tools/build/mac/run_verify_order.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698