third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 1980133002: Implement pointer lock API for out-of-process iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 1980133002: Implement pointer lock API for out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_widget_mouse_lock_dispatcher.cc ('K') | « third_party/WebKit/Source/core/page/PointerLockController.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index 819a9a814f2b72eae4fd0de243f31bdbed2819df..3b0a6a17667d62a20a6f138f55739719f48924f4 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -156,8 +156,8 @@ public:

bool shouldOpenModalDialogDuringPageDismissal(const DialogType&, const String& dialogMessage, Document::PageDismissalType) const override;

- bool requestPointerLock() override;

- void requestPointerUnlock() override;

+ bool requestPointerLock(LocalFrame*) override;

+ void requestPointerUnlock(LocalFrame*) override;

// AutofillClient pass throughs:

void didAssociateFormControls(const HeapVector<Member<Element>>&, LocalFrame*) override;