Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: content/renderer/mouse_lock_dispatcher_browsertest.cc

Issue 1980133002: Implement pointer lock API for out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/mouse_lock_dispatcher_browsertest.cc
diff --git a/content/renderer/mouse_lock_dispatcher_browsertest.cc b/content/renderer/mouse_lock_dispatcher_browsertest.cc
index 2a0fd6b4778e7bd4370e28018408144be61ce8ab..685da6d7b57e1a51423e6261ecb05572aef36e23 100644
--- a/content/renderer/mouse_lock_dispatcher_browsertest.cc
+++ b/content/renderer/mouse_lock_dispatcher_browsertest.cc
@@ -30,7 +30,7 @@ class MouseLockDispatcherTest : public RenderViewTest {
public:
void SetUp() override {
RenderViewTest::SetUp();
- route_id_ = view()->GetRoutingID();
+ route_id_ = view()->GetWidget()->routing_id();
target_ = new MockLockTarget();
alternate_target_ = new MockLockTarget();
}
@@ -43,6 +43,7 @@ class MouseLockDispatcherTest : public RenderViewTest {
protected:
RenderViewImpl* view() { return static_cast<RenderViewImpl*>(view_); }
+ RenderWidget* widget() { return view()->GetWidget(); }
MouseLockDispatcher* dispatcher() { return view()->mouse_lock_dispatcher(); }
int route_id_;
MockLockTarget* target_;
@@ -54,22 +55,22 @@ class MouseLockDispatcherTest : public RenderViewTest {
// Test simple use of RenderViewImpl interface to WebKit for pointer lock.
TEST_F(MouseLockDispatcherTest, BasicWebWidget) {
// Start unlocked.
- EXPECT_FALSE(view()->isPointerLocked());
+ EXPECT_FALSE(widget()->isPointerLocked());
// Lock.
- EXPECT_TRUE(view()->requestPointerLock());
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
- EXPECT_TRUE(view()->isPointerLocked());
+ EXPECT_TRUE(widget()->requestPointerLock());
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
+ EXPECT_TRUE(widget()->isPointerLocked());
// Unlock.
- view()->requestPointerUnlock();
- view()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
- EXPECT_FALSE(view()->isPointerLocked());
+ widget()->requestPointerUnlock();
+ widget()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
+ EXPECT_FALSE(widget()->isPointerLocked());
// Attempt a lock, and have it fail.
- EXPECT_TRUE(view()->requestPointerLock());
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, false));
- EXPECT_FALSE(view()->isPointerLocked());
+ EXPECT_TRUE(widget()->requestPointerLock());
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, false));
+ EXPECT_FALSE(widget()->isPointerLocked());
}
// Test simple use of MouseLockDispatcher with a mock LockTarget.
@@ -86,7 +87,7 @@ TEST_F(MouseLockDispatcherTest, BasicMockLockTarget) {
// Lock.
EXPECT_TRUE(dispatcher()->LockMouse(target_));
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
EXPECT_TRUE(dispatcher()->IsMouseLockedTo(target_));
// Receive mouse event.
@@ -94,12 +95,12 @@ TEST_F(MouseLockDispatcherTest, BasicMockLockTarget) {
// Unlock.
dispatcher()->UnlockMouse(target_);
- view()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
+ widget()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
EXPECT_FALSE(dispatcher()->IsMouseLockedTo(target_));
// Attempt a lock, and have it fail.
EXPECT_TRUE(dispatcher()->LockMouse(target_));
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, false));
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, false));
EXPECT_FALSE(dispatcher()->IsMouseLockedTo(target_));
}
@@ -112,7 +113,7 @@ TEST_F(MouseLockDispatcherTest, DeleteAndUnlock) {
// Lock.
EXPECT_TRUE(dispatcher()->LockMouse(target_));
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
EXPECT_TRUE(dispatcher()->IsMouseLockedTo(target_));
// Unlock, with a deleted target.
@@ -121,7 +122,7 @@ TEST_F(MouseLockDispatcherTest, DeleteAndUnlock) {
delete target_;
target_ = NULL;
dispatcher()->WillHandleMouseEvent(blink::WebMouseEvent());
- view()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
+ widget()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
EXPECT_FALSE(dispatcher()->IsMouseLockedTo(target_));
}
@@ -140,7 +141,7 @@ TEST_F(MouseLockDispatcherTest, DeleteWithPendingLockSuccess) {
target_ = NULL;
// Lock response.
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
}
// Test deleting a target that is pending a lock request failure response.
@@ -158,7 +159,7 @@ TEST_F(MouseLockDispatcherTest, DeleteWithPendingLockFail) {
target_ = NULL;
// Lock response.
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, false));
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, false));
}
// Test not receiving mouse events when a target is not locked.
@@ -175,7 +176,7 @@ TEST_F(MouseLockDispatcherTest, MouseEventsNotReceived) {
// Lock.
EXPECT_TRUE(dispatcher()->LockMouse(target_));
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
EXPECT_TRUE(dispatcher()->IsMouseLockedTo(target_));
// Receive mouse event.
@@ -183,7 +184,7 @@ TEST_F(MouseLockDispatcherTest, MouseEventsNotReceived) {
// Unlock.
dispatcher()->UnlockMouse(target_);
- view()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
+ widget()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
EXPECT_FALSE(dispatcher()->IsMouseLockedTo(target_));
// (Don't) receive mouse event.
@@ -208,7 +209,7 @@ TEST_F(MouseLockDispatcherTest, MultipleTargets) {
EXPECT_FALSE(dispatcher()->LockMouse(alternate_target_));
// Lock completion for target.
- view()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
+ widget()->OnMessageReceived(ViewMsg_LockMouse_ACK(route_id_, true));
EXPECT_TRUE(dispatcher()->IsMouseLockedTo(target_));
// Fail attempt to lock alternate.
@@ -226,7 +227,7 @@ TEST_F(MouseLockDispatcherTest, MultipleTargets) {
// Though the call to UnlockMouse should not unlock any target, we will
// cause an unlock (as if e.g. user escaped mouse lock) and verify the
// correct target is unlocked.
- view()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
+ widget()->OnMessageReceived(ViewMsg_MouseLockLost(route_id_));
EXPECT_FALSE(dispatcher()->IsMouseLockedTo(target_));
}
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698