Drop [LegacyImplementedInBaseClass] attribute from WindowTimers

Source/core/page/DOMWindowTimers.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
@@ skipping 13 matching lines @@
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-#include "core/page/DOMWindowBase64.h"
+#include "core/page/DOMWindowTimers.h"
 
-#include "wtf/text/Base64.h"
+#include "core/dom/EventTarget.h"
+#include "core/page/DOMTimer.h"
 
 namespace WebCore {
 
-namespace DOMWindowBase64 {
+namespace DOMWindowTimers {

[haraken, 2013/07/19 11:25:44]

Why do you use a namespace instead of a class? I expected:

  class DOMWindowTimers {
    static int setTimeout(...);
  };

this is just for consistency with how partial interfaces are implemented.

 
-String btoa(void*, const String& stringToEncode, ExceptionCode& ec)
+int setTimeout(EventTarget* eventTarget, PassOwnPtr<ScheduledAction> action, int timeout)
 {
-    if (stringToEncode.isNull())
-        return String();
-
-    if (!stringToEncode.containsOnlyLatin1()) {
-        ec = InvalidCharacterError;
-        return String();
-    }
-
-    return base64Encode(stringToEncode.latin1());
+    return DOMTimer::install(eventTarget->scriptExecutionContext(), action, timeout, true);
 }
 
-String atob(void*, const String& encodedString, ExceptionCode& ec)
+int setInterval(EventTarget* eventTarget, PassOwnPtr<ScheduledAction> action, int timeout)
 {
-    if (encodedString.isNull())
-        return String();
-
-    if (!encodedString.containsOnlyLatin1()) {
-        ec = InvalidCharacterError;
-        return String();
-    }
-
-    Vector<char> out;
-    if (!base64Decode(encodedString, out, Base64FailOnInvalidCharacter, Base64StrictPaddingValidation)) {
-        ec = InvalidCharacterError;
-        return String();
-    }
-
-    return String(out.data(), out.size());
+    return DOMTimer::install(eventTarget->scriptExecutionContext(), action, timeout, false);
 }
 
-} // namespace DOMWindowBase64
+void clearTimeout(EventTarget* eventTarget, int timeoutID)
+{
+    if (ScriptExecutionContext* context = eventTarget->scriptExecutionContext())
+        DOMTimer::removeByID(context, timeoutID);
+}
+
+void clearInterval(EventTarget* eventTarget, int timeoutID)
+{
+    if (ScriptExecutionContext* context = eventTarget->scriptExecutionContext())
+        DOMTimer::removeByID(context, timeoutID);
+}
+
+} // namespace DOMWindowTimers
 
 } // namespace WebCore