components/ntp_snippets/ntp_snippets_service.h - Issue 1980033002: [NTP Snippets] Clear the snippets when the user signs out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 1980033002: [NTP Snippets] Clear the snippets when the user signs out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('K') | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.h

diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h

index 13e949afb04dd48467f35c90321bb8acf9c4e08f..9d347c9c5b10ad82b8c167e1a875713dece1cfeb 100644

--- a/components/ntp_snippets/ntp_snippets_service.h

+++ b/components/ntp_snippets/ntp_snippets_service.h

@@ -198,6 +198,8 @@ class NTPSnippetsServiceObserver {

virtual void NTPSnippetsServiceLoaded() = 0;

// Sent when the service is shutting down.

virtual void NTPSnippetsServiceShutdown() = 0;

+ // Sent every time the service has its data sources cleared.

Bernhard Bauer 2016/05/17 09:12:48 Maybe add a comment that explains why we do this?

dgn 2016/05/17 10:46:00 Added comments both here and in snippets_bridge.cc

+ virtual void NTPSnippetsServiceCleared() = 0;

protected:

virtual ~NTPSnippetsServiceObserver() {}