Chromium Code Reviews Chromium Code Reviews
Issue
198003008:
Implement support for expanding crop rects in image filters (Closed)
DescriptionImplement support for expanding crop rects in image filters
NOTE: this patch set is based on https://codereview.chromium.org/189913021/,
and needs that patch to land first.
Until now, crop rects in Skia have only been able to reduce
the size of the destination bounds, but not expand them.
SVG semantics require the latter as well. The heart of
the change is in applyCropRect(), which now assigns each
edge, instead of doing an intersection with the crop rect.
In order to support this (and still work well with tiled
drawing) we need to clip the resulting crop rect to the
clipping region of the filters. This uses the Context struct
previously landed from https://codereview.chromium.org/189913021/.
Many of the pixel loops are not yet ready to handle a
destination rect larger than the source rect. So we provide
a convenience version of applyCropRect() which creates an
offscreen and pads it out with transparent black. Once the
pixel loops and shaders have been fixed to support larger
destination bounds, they should be switched back to the
non-drawing version of applyCropRect().
BUG=skia:
R=bsalomon@google.com, reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=13805
Committed: https://code.google.com/p/skia/source/detail?r=13809
Patch Set 1 #
Total comments: 3
Patch Set 2 : Reorder applyCropRect() params; fix 100-col issues; tweak GM #
Total comments: 4
Patch Set 3 : Fixed this-> nits #Patch Set 4 : Fixed nits (w/correct upstream) #Patch Set 5 : Rebase to ToT; fix Win32 #Patch Set 6 : Fix ImageFilterTest #
Messages
Total messages: 9 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
