Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: scripts/run_cmd.py

Issue 198003006: Remove logging (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/run_cmd.py
diff --git a/scripts/run_cmd.py b/scripts/run_cmd.py
index 247c9a638f28597deb8bd9a18720ebc0dce219b9..a30d2d5caea666c316d28e5a9bb7807f2e3b66ba 100755
--- a/scripts/run_cmd.py
+++ b/scripts/run_cmd.py
@@ -172,8 +172,6 @@ def _launch_cmd(cmd):
Returns:
subprocess.Popen instance.
"""
- print ' '.join(cmd)
- subprocess.call(cmd)
return subprocess.Popen(cmd, shell=False, stderr=subprocess.PIPE,
stdout=subprocess.PIPE)
@@ -186,9 +184,6 @@ def _get_result(popen):
Returns:
A dictionary with stdout, stderr, and returncode as keys.
"""
- for fd in (popen.stdout, popen.stderr):
- for line in iter(fd.readline, ''):
- print line
stdout, stderr = popen.communicate()
return CommandResults.make(stdout=stdout,
stderr=stderr,
@@ -312,7 +307,6 @@ def run_on_all_slave_hosts(cmd):
procs.append((hostname, _launch_on_remote_host(hostname, cmd)))
for slavename, proc in procs:
- print 'Awaiting results from %s' % slavename
results.update(_get_remote_host_results(slavename, proc))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698