Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1980013002:
Simplify LoadableTextTrack::trackElementIndex (Closed)
|
Created:
4 years, 7 months ago by fs Modified:
4 years, 7 months ago Reviewers:
davve CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, gasubic, nessy, vcarbune.chromium Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of Simplify LoadableTextTrack::trackElementIndex
Count preceding sibling <track> elements in a more straight-forward way.
Also clean-up null-checks of m_trackElement while here (should be non-
null on construction and then keeps a strong reference.)
Committed: https://crrev.com/d395a0e281f42ca4b5edf8543779724bc54b7e86
Cr-Commit-Position: refs/heads/master@{#394166}
Patch Set 1 #Patch Set 2 : Use a for-loop #
Messages
Total messages: 22 (9 generated)
fs@opera.com changed reviewers: + davve@opera.com
Looks very reasonable. lgtm.
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980013002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) ========== to ========== Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) Committed: https://crrev.com/0537a6d11bf2ebefcf90fbfec7081e37ef78081a Cr-Commit-Position: refs/heads/master@{#393825} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0537a6d11bf2ebefcf90fbfec7081e37ef78081a Cr-Commit-Position: refs/heads/master@{#393825}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1985643003/ by fs@opera.com. The reason for reverting is: Seems "WebKit Win Builder (dbg)" didn't approve: e:\b\build\slave\webkit-win-latest-dbg\build\src\third_party\webkit\source\core\html\track\loadabletexttrack.cpp(70) : warning C4706: assignment within conditional expression.
Description was changed from ========== Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) Committed: https://crrev.com/0537a6d11bf2ebefcf90fbfec7081e37ef78081a Cr-Commit-Position: refs/heads/master@{#393825} ========== to ========== Reland of Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) Committed: https://crrev.com/0537a6d11bf2ebefcf90fbfec7081e37ef78081a Cr-Commit-Position: refs/heads/master@{#393825} ==========
On 2016/05/16 at 13:50:35, fs wrote: > A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1985643003/ by fs@opera.com. > > The reason for reverting is: Seems "WebKit Win Builder (dbg)" didn't approve: > > e:\b\build\slave\webkit-win-latest-dbg\build\src\third_party\webkit\source\core\html\track\loadabletexttrack.cpp(70) : warning C4706: assignment within conditional expression. Rewrote to use a for-loop instead to (hopefully) appease the Win bots... will attempt to reland.
Description was changed from ========== Reland of Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) Committed: https://crrev.com/0537a6d11bf2ebefcf90fbfec7081e37ef78081a Cr-Commit-Position: refs/heads/master@{#393825} ========== to ========== Reland of Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) ==========
still lgtm
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980013002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980013002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Reland of Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) ========== to ========== Reland of Simplify LoadableTextTrack::trackElementIndex Count preceding sibling <track> elements in a more straight-forward way. Also clean-up null-checks of m_trackElement while here (should be non- null on construction and then keeps a strong reference.) Committed: https://crrev.com/d395a0e281f42ca4b5edf8543779724bc54b7e86 Cr-Commit-Position: refs/heads/master@{#394166} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d395a0e281f42ca4b5edf8543779724bc54b7e86 Cr-Commit-Position: refs/heads/master@{#394166} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
