Hide knowledge of webkit::ppapi::PluginDelegate from chrome. This is part of moving ppapi implement…

chrome/renderer/pepper/ppb_pdf_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/pepper/ppb_pdf_impl.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/safe_numerics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/printing/print_web_view_helper.h"
 #include "content/public/common/child_process_sandbox_support_linux.h"
 #include "content/public/common/content_client.h"
+#include "content/public/common/referrer.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "grit/webkit_resources.h"
 #include "grit/webkit_strings.h"
 #include "ppapi/c/pp_resource.h"
 #include "ppapi/c/private/ppb_pdf.h"
 #include "ppapi/shared_impl/resource.h"
 #include "ppapi/shared_impl/resource_tracker.h"
 #include "ppapi/shared_impl/var.h"
 #include "skia/ext/platform_canvas.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebPluginContainer.h"
+#include "third_party/WebKit/public/web/WebView.h"
 #include "third_party/icu/source/i18n/unicode/usearch.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/layout.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_rep.h"
 #include "webkit/plugins/ppapi/host_globals.h"
-#include "webkit/plugins/ppapi/plugin_delegate.h"
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 #include "webkit/plugins/ppapi/ppb_image_data_impl.h"
 
 using ppapi::PpapiGlobals;
 using webkit::ppapi::HostGlobals;
 using webkit::ppapi::PluginInstance;
 using WebKit::WebElement;
 using WebKit::WebView;
 using content::RenderThread;
 
@@ skipping 239 matching lines @@
   }
 
   usearch_close(searcher);
 }
 
 void DidStartLoading(PP_Instance instance_id) {
   PluginInstance* instance =
       content::GetHostGlobals()->GetInstance(instance_id);
   if (!instance)
     return;
-  instance->delegate()->DidStartLoading();
+  instance->render_view()->DidStartLoading();
 }
 
 void DidStopLoading(PP_Instance instance_id) {
   PluginInstance* instance =
       content::GetHostGlobals()->GetInstance(instance_id);
   if (!instance)
     return;
-  instance->delegate()->DidStopLoading();
+  instance->render_view()->DidStopLoading();
 }
 
 void SetContentRestriction(PP_Instance instance_id, int restrictions) {
   PluginInstance* instance =
       content::GetHostGlobals()->GetInstance(instance_id);
   if (!instance)
     return;
-  instance->delegate()->SetContentRestriction(restrictions);
+  instance->render_view()->Send(
+      new ChromeViewHostMsg_PDFUpdateContentRestrictions(
+          instance->render_view()->GetRoutingID(), restrictions));
 }
 
 void HistogramPDFPageCount(PP_Instance /*instance*/, int count) {
   UMA_HISTOGRAM_COUNTS_10000("PDF.PageCount", count);
 }
 
 void UserMetricsRecordAction(PP_Instance /*instance*/, PP_Var action) {
   scoped_refptr<ppapi::StringVar> action_str(
       ppapi::StringVar::FromPPVar(action));
   if (action_str.get())
@@ skipping 14 matching lines @@
   content::RenderView* render_view = content::RenderView::FromWebView(view);
   render_view->Send(new ChromeViewHostMsg_PDFHasUnsupportedFeature(
       render_view->GetRoutingID()));
 }
 
 void SaveAs(PP_Instance instance_id) {
   PluginInstance* instance =
       content::GetHostGlobals()->GetInstance(instance_id);
   if (!instance)
     return;
-  instance->delegate()->SaveURLAs(instance->plugin_url());
+  GURL url = instance->plugin_url();
+
+  content::RenderView* render_view = instance->render_view();
+  WebKit::WebFrame* frame = render_view->GetWebView()->mainFrame();
+  content::Referrer referrer(frame->document().url(),

[scottmg, 2013/07/23 00:34:16]

i don't know anything about the lifetimes here, is it possible for the frame to
be gone?

[jam, 2013/07/23 00:42:03]

this is code I moved from PepperPluginDelegateImpl::SaveURLAs, so there should
be no change in behavior.

https://codereview.chromium.org/19800005/diff/18003/content/renderer/pepper/p...

+                             frame->document().referrerPolicy());
+  render_view->Send(new ChromeViewHostMsg_PDFSaveURLAs(
+      render_view->GetRoutingID(), url, referrer));
 }
 
 PP_Bool IsFeatureEnabled(PP_Instance instance, PP_PDFFeature feature) {
   switch (feature) {
     case PP_PDFFEATURE_HIDPI:
       return PP_TRUE;
     case PP_PDFFEATURE_PRINTING:
       return IsPrintingEnabled(instance) ? PP_TRUE : PP_FALSE;
   }
   return PP_FALSE;
@@ skipping 86 matching lines @@
 
 // static
 void PPB_PDF_Impl::InvokePrintingForInstance(PP_Instance instance_id) {
 #if defined(ENABLE_PRINTING)
   WebKit::WebElement element = GetWebElement(instance_id);
   printing::PrintWebViewHelper* helper = GetPrintWebViewHelper(element);
   if (helper)
     helper->PrintNode(element);
 #endif  // ENABLE_PRINTING
 }