Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 19800005: Hide knowledge of webkit::ppapi::PluginDelegate from chrome. This is part of moving ppapi implement… (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, asanka, Avi (use Gerrit), creis+watch_chromium.org, benjhayden+dwatch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Hide knowledge of webkit::ppapi::PluginDelegate from chrome. This is part of moving ppapi implementation from webkit/plugins/ppapi to content/renderer. Chrome used four methods on that interface for PDFs. -DidStartLoading/DidStopLoading: I just exposed these methods from RenderViewImpl on the RenderView interface -SetContentRestriction: I moved this functionality completely into chrome. This allows us to get rid of all the content restrictions related methods in the content API, and to move content_restriction.h out to chrome. -SaveURLAs: exposed the internal SaveURL method on WebContents BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213027

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix android #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -204 lines) Patch
M chrome/browser/download/download_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 4 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_tab_helper.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_tab_helper.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.h View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 1 2 3 chunks +20 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/common/content_restriction.h View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_pdf_host.cc View 6 chunks +14 lines, -4 lines 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 7 chunks +15 lines, -5 lines 2 comments Download
M content/browser/download/download_stats.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 5 chunks +2 lines, -12 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 10 chunks +28 lines, -56 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/web_contents.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
D content/public/common/content_restriction.h View 1 chunk +0 lines, -22 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 3 chunks +1 line, -23 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 chunk +0 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 5 chunks +8 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.cc View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
7 years, 5 months ago (2013-07-22 23:17:55 UTC) #1
scottmg
lgtm, but maybe get some a pepper person to look too? https://codereview.chromium.org/19800005/diff/18003/chrome/renderer/pepper/ppb_pdf_impl.cc File chrome/renderer/pepper/ppb_pdf_impl.cc (right): ...
7 years, 5 months ago (2013-07-23 00:34:16 UTC) #2
jam
https://codereview.chromium.org/19800005/diff/18003/chrome/renderer/pepper/ppb_pdf_impl.cc File chrome/renderer/pepper/ppb_pdf_impl.cc (right): https://codereview.chromium.org/19800005/diff/18003/chrome/renderer/pepper/ppb_pdf_impl.cc#newcode357 chrome/renderer/pepper/ppb_pdf_impl.cc:357: content::Referrer referrer(frame->document().url(), On 2013/07/23 00:34:16, scottmg wrote: > i ...
7 years, 5 months ago (2013-07-23 00:42:03 UTC) #3
jam
On 2013/07/23 00:34:16, scottmg wrote: > lgtm, but maybe get some a pepper person to ...
7 years, 5 months ago (2013-07-23 00:55:00 UTC) #4
scottmg
7 years, 5 months ago (2013-07-23 00:56:10 UTC) #5
On 2013/07/23 00:55:00, jam wrote:
> On 2013/07/23 00:34:16, scottmg wrote:
> > lgtm, but maybe get some a pepper person to look too?
> 
> for most of the changes I will do in that directory, I'll send the change to a
> pepper person. but this stuff is just basic refactorings of code that I wrote,
> so I think your review will be enough :)

yup, fine with me.

Powered by Google App Engine
This is Rietveld 408576698