build/config/sanitizers/sanitizers.gni - Issue 1979973002: Correctly set -stdlib=libc++ when building with a custom libc++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 1979973002: Correctly set -stdlib=libc++ when building with a custom libc++. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/sanitizers/sanitizers.gni

diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni

index 7d6a79fb2bc4c23e71806e951c63ee71466e3aa7..1c08112da23a7dc9adb40ddac7871a0f96bede75 100644

--- a/build/config/sanitizers/sanitizers.gni

+++ b/build/config/sanitizers/sanitizers.gni

@@ -80,8 +80,9 @@ declare_args() {

# Use libc++ (buildtools/third_party/libc++ and

# buildtools/third_party/libc++abi) instead of stdlibc++ as standard library.

# This is intended to be used for instrumented builds.

- use_custom_libcxx = (is_asan && is_linux) || is_tsan || is_msan || is_ubsan ||

- is_ubsan_security || use_libfuzzer

+ use_custom_libcxx =

+ (is_asan && is_linux && !is_android && !is_chromeos) || is_tsan ||

Dirk Pranke 2016/05/19 05:17:26 you shouldn't need !is_android here; is_linux impl

Sam McNally 2016/05/19 07:38:06 Done.

+ is_msan || is_ubsan || is_ubsan_security || use_libfuzzer

# Enable -fsanitize-coverage.

use_sanitizer_coverage = use_libfuzzer || sanitizer_coverage_flags != ""

« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »