Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1979913002: Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext Since GrDrawingContext is generally replacing GrRenderTarget, this is to provide functionality similar to GrRenderTarget::wasDestroyed. This is split out of https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1979913002 Committed: https://skia.googlesource.com/skia/+/7761d61876ea479dd9672b684fd5c7601932a767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPathRenderingDrawContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
4 years, 7 months ago (2016-05-15 18:29:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979913002/1
4 years, 7 months ago (2016-05-15 18:29:25 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-15 18:51:16 UTC) #10
bsalomon
lgtm
4 years, 7 months ago (2016-05-16 13:30:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979913002/1
4 years, 7 months ago (2016-05-16 16:14:00 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 16:14:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7761d61876ea479dd9672b684fd5c7601932a767

Powered by Google App Engine
This is Rietveld 408576698