build/android/pylib/gtest/test_package_apk.py - Issue 19799003: [android] Instumentation tests determine whether to install test apk based on Md5Sum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 19799003: [android] Instumentation tests determine whether to install test apk based on Md5Sum. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: removed install of APK to be tested, turns out there isn't a consistent pattern to the naming Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/android_commands.py ('k') | build/android/pylib/host_driven/python_test_base.py » ('j') | build/android/pylib/instrumentation/test_package.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/gtest/test_package_apk.py

diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py

index 27dad352b6cf57fcb652e918e995947592453e95..1ea0f8892451f6d5f3d0d84acc8f3bda26adce8d 100644

--- a/build/android/pylib/gtest/test_package_apk.py

+++ b/build/android/pylib/gtest/test_package_apk.py

@@ -88,15 +88,6 @@ class TestPackageApk(TestPackage):

action='android.intent.action.MAIN',

force_stop=True)

- def _NeedsInstall(self):

- installed_apk_path = self.adb.GetApplicationPath(

- self._test_apk_package_name)

- if installed_apk_path:

- return not self.adb.CheckMd5Sum(

- self.suite_path_full, installed_apk_path, ignore_paths=True)

- else:

- return True

def _GetTestSuiteBaseName(self):

"""Returns the base name of the test suite."""

# APK test suite names end with '-debug.apk'

@@ -143,8 +134,6 @@ class TestPackageApk(TestPackage):

#override

def Install(self):

self.tool.CopyFiles()

- if self._NeedsInstall():

- # Always uninstall the previous one (by activity name); we don't

- # know what was embedded in it.

- self.adb.ManagedInstall(self.suite_path_full, False,

- package_name=self._test_apk_package_name)

+ self.adb.ManagedInstall(self.suite_path_full, False,

+ package_name=self._test_apk_package_name)