Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1979883002:
Reland changes to v8_snapshot GN build arg. (Closed)
|
Created:
4 years, 7 months ago by Dirk Pranke Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com, stevenjb, hashimoto Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionReland changes to v8_snapshot GN build arg.
This patch re-lands #36193 with a couple of minor tweaks
including updating the BUILD.gn file to use the new
variable name and incorporating thakis' request to support
cross-compiling the win snapshot from a mac.
R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org
BUG=608596, 595653
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng
Committed: https://crrev.com/b6168e1223d266dba1a357a921bc84ae97a1d803
Cr-Commit-Position: refs/heads/master@{#36342}
Patch Set 1 #Patch Set 2 : make cros backwards-compatible for now #Messages
Total messages: 26 (12 generated)
I need to think about how to land this CL and https://codereview.chromium.org/1983613002/ to be sure that nothing breaks, so this isn't 100% ready for review, but it's mostly there.
Description was changed from ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 ========== to ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 ==========
On 2016/05/15 01:36:18, Dirk Pranke wrote: > I need to think about how to land this CL and > https://codereview.chromium.org/1983613002/ to be sure that nothing breaks, so > this isn't 100% ready for review, but it's mostly there. I think if we land the other CL first, things should be okay. Really we will need to rework use_sysroot and use_clang to be more flexible across multiple toolchains, but that will probably need to wait for brettw's review.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979883002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stevenjb@chromium.org changed reviewers: + stevenjb@chromium.org
Not an owner but I tested this with https://codereview.chromium.org/1983613002/ and https://chromium-review.googlesource.com/#/c/344912/. LGTM
adamk@chromium.org changed reviewers: + adamk@chromium.org
lgtm as long as you wait for the Chromium side to land first (naturally).
Description was changed from ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 ========== to ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng ==========
lgtm - note that we can use any chromium trybot on v8 patches to preview their effect. I formalized the need of the other patch to land first by adding this line to the description (CQ will trigger that bot): CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng I also triggered it manually once FYI.
On 2016/05/17 08:02:25, Michael Achenbach (slow) wrote: > lgtm - note that we can use any chromium trybot on v8 patches to preview their > effect. I formalized the need of the other patch to land first by adding this > line to the description (CQ will trigger that bot): > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng > > I also triggered it manually once FYI. Thanks for the review/tip/tryjob. The failure is as I'd expect since the Chromium-side CL hasn't landed yet.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979883002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org, adamk@chromium.org, machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/1979883002/#ps20001 (title: "make cros backwards-compatible for now")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979883002/20001
Message was sent while issue was closed.
Description was changed from ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng ========== to ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng ========== to ========== Reland changes to v8_snapshot GN build arg. This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng Committed: https://crrev.com/b6168e1223d266dba1a357a921bc84ae97a1d803 Cr-Commit-Position: refs/heads/master@{#36342} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b6168e1223d266dba1a357a921bc84ae97a1d803 Cr-Commit-Position: refs/heads/master@{#36342}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1996533002/ by machenbach@chromium.org. The reason for reverting is: Blocks the roll again: https://codereview.chromium.org/1993163002/ https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64... Lets add chromeos_amd64-generic_chromium_compile_only_ng on a reland as well.. |
