Source/core/svg/animation/SVGSMILElement.cpp - Issue 19798009: Introduce toSVGSMILElement, and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 19798009: Introduce toSVGSMILElement, and use it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index b84205a95ed9eb8f7a5adc1f246e7e84a17ed50e..3c78b9409f20069e689c4f10eb42390536b255cc 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -536,7 +536,7 @@ void SVGSMILElement::connectConditions()

condition.m_syncbase = 0;

continue;

}

- SVGSMILElement* syncbase = static_cast<SVGSMILElement*>(condition.m_syncbase.get());

+ SVGSMILElement* syncbase = toSVGSMILElement(condition.m_syncbase.get());

tkent 2013/07/24 05:19:26 We can remove the local variable |syncbase|.

syncbase->addTimeDependent(this);

}

@@ -566,7 +566,7 @@ void SVGSMILElement::disconnectConditions()

} else if (condition.m_type == Condition::Syncbase) {

if (condition.m_syncbase) {

ASSERT(isSMILElement(condition.m_syncbase.get()));

tkent 2013/07/24 05:19:26 This assertion is redundant. toSVgSMILElement() c

- static_cast<SVGSMILElement*>(condition.m_syncbase.get())->removeTimeDependent(this);

+ toSVGSMILElement(condition.m_syncbase.get())->removeTimeDependent(this);

}

condition.m_syncbase = 0;

« no previous file with comments | « Source/core/svg/animation/SVGSMILElement.h ('k') | no next file » | no next file with comments »