Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19798009: Introduce toSVGSMILElement, and use it (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, f(malita), darktears, pdr, Stephen Chennney, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGSMILElement, and use it As a step to change static_cast with toSVGXXX, static_cast<SVGSMILElement*> can be changed with toSVGSMILElement(). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155048

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed redundant code #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gyuyoung-inactive
Add tkent as reviewer.
7 years, 5 months ago (2013-07-24 04:43:56 UTC) #1
tkent
https://codereview.chromium.org/19798009/diff/1/Source/core/svg/animation/SVGSMILElement.cpp File Source/core/svg/animation/SVGSMILElement.cpp (right): https://codereview.chromium.org/19798009/diff/1/Source/core/svg/animation/SVGSMILElement.cpp#newcode539 Source/core/svg/animation/SVGSMILElement.cpp:539: SVGSMILElement* syncbase = toSVGSMILElement(condition.m_syncbase.get()); We can remove the local ...
7 years, 5 months ago (2013-07-24 05:19:26 UTC) #2
gyuyoung-inactive
On 2013/07/24 05:19:26, tkent wrote: > https://codereview.chromium.org/19798009/diff/1/Source/core/svg/animation/SVGSMILElement.cpp > File Source/core/svg/animation/SVGSMILElement.cpp (right): > > https://codereview.chromium.org/19798009/diff/1/Source/core/svg/animation/SVGSMILElement.cpp#newcode539 > ...
7 years, 5 months ago (2013-07-24 07:54:56 UTC) #3
tkent
lgtm
7 years, 5 months ago (2013-07-24 07:56:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19798009/6
7 years, 5 months ago (2013-07-24 07:56:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14467
7 years, 5 months ago (2013-07-24 10:39:28 UTC) #6
gyuyoung-inactive
On 2013/07/24 10:39:28, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 4 months ago (2013-07-27 03:59:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19798009/18001
7 years, 4 months ago (2013-07-27 06:55:42 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-07-27 12:22:40 UTC) #9
Message was sent while issue was closed. 
Change committed as 155048

Powered by Google App Engine
This is Rietveld 408576698