Faster to number conversion

src/hydrogen-instructions.h

Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index a006c44dd54705d90ddf4a041be3e2126b652257..9d87fa0be03686d4f69a9768751ae0ccf1d92754 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -407,6 +407,14 @@ class HType {
     return ((type_ & kString) == kString);
   }
 
+  bool IsNoString() const {

[Toon Verwaest, 2013/07/22 08:30:21]

Can we name this IsNonString, in line with IsNonPrimitive?

[oliv, 2013/07/22 13:56:43]

Done.

+    if (IsTaggedPrimitive() || IsSmi() || IsHeapNumber() ||

[Sven Panne, 2013/07/22 07:06:36]

o_O o_O o_O

return IsTaggedPrimitive() || IsSmi() || IsHeapNumber() || IsBoolean() ||
IsJSArray();

[oliv, 2013/07/22 07:34:30]

lol, that's embarrassing

+        IsBoolean() || IsJSArray()) {
+      return true;
+    }
+    return false;
+  }
+
   bool IsBoolean() const {
     ASSERT(type_ != kUninitialized);
     return ((type_ & kBoolean) == kBoolean);
@@ -3350,7 +3358,8 @@ class HConstant: public HTemplateInstruction<0> {
   virtual HType CalculateInferredType();
   bool IsInteger() { return handle()->IsSmi(); }
   HConstant* CopyToRepresentation(Representation r, Zone* zone) const;
-  HConstant* CopyToTruncatedInt32(Zone* zone) const;
+  HConstant* CopyToTruncatedInt32(Zone* zone);

[Toon Verwaest, 2013/07/22 08:30:21]

I guess you tried hard to keep this const? I'd prefer to keep it; but if it's
too hard... meh :)

[oliv, 2013/07/22 13:56:43]

the problem is deferred handle dereference in TruncateToNumber

+  HConstant* CopyToTruncatedNumber(Zone* zone);

[Jakob Kummerow, 2013/07/22 07:43:47]

This sounds more generic than it is. How about "CopyOddballToNumber"?

[Toon Verwaest, 2013/07/22 08:30:21]

I think the original name is fine. CopyToTruncatedInt32 doesn't handle all cases
either, and will return NULL if not possible. We could rename both to
TryCopyToTruncated* though.

On 2013/07/22 07:43:47, Jakob wrote:

[oliv, 2013/07/22 13:56:43]

How about returning Maybe<>, now it is clear, that the conversion is partial

   bool HasInteger32Value() const { return has_int32_value_; }
   int32_t Integer32Value() const {
     ASSERT(HasInteger32Value());