content/browser/download/download_request_core.cc - Issue 1979783002: [Merge M51][Downloads] Use the initiating StoragePartition for resumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_request_core.cc

Issue 1979783002: [Merge M51][Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/download_manager_impl_unittest.cc ('k') | content/browser/download/download_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_request_core.cc

diff --git a/content/browser/download/download_request_core.cc b/content/browser/download/download_request_core.cc

index 3f70e956baa78676b3a19f3968bc4825098a6865..75455c6109f22d4637c4a126cc663b2cacc6266e 100644

--- a/content/browser/download/download_request_core.cc

+++ b/content/browser/download/download_request_core.cc

@@ -112,8 +112,9 @@ scoped_ptr<net::URLRequest> DownloadRequestCore::CreateRequestOnIOThread(

// DownloadUrlParameters can-not include resource_dispatcher_host_impl.h, so

// we must down cast. RDHI is the only subclass of RDH as of 2012 May 4.

scoped_ptr<net::URLRequest> request(

- params->resource_context()->GetRequestContext()->CreateRequest(

- params->url(), net::DEFAULT_PRIORITY, nullptr));

+ params->url_request_context_getter()

+ ->GetURLRequestContext()

+ ->CreateRequest(params->url(), net::DEFAULT_PRIORITY, nullptr));

request->set_method(params->method());

if (!params->post_body().empty()) {

@@ -181,7 +182,7 @@ scoped_ptr<net::URLRequest> DownloadRequestCore::CreateRequestOnIOThread(

request->SetExtraRequestHeaderByName(header.first, header.second,

false /*overwrite*/);

- DownloadRequestData::Attach(request.get(), std::move(params), download_id);

+ DownloadRequestData::Attach(request.get(), params, download_id);

return request;

}