Landing Recent QUIC changes until Sun May 8 00:39:29 2016 +0000

Landing Recent QUIC changes until Sun May 8 00:39:29 2016 +0000
Combine OnCongestionWindowChange and OnRttChange to OnCongestionChange in QuicSentPacketManager::NetworkChangeVisitor. No functional change expected.

Merge internal change: 121761990
https://codereview.chromium.org/1981643002/

Clean up the pretty-printing of QUIC frames to be internally consistent.

Merge internal change: 121732198
https://codereview.chromium.org/1979633003/

Rename the QUIC stream frame fields frame_buffer and frame_length to data_buffer and data_length because they do only contain info about the *data* not the full frame.

Merge internal change: 121705514
https://codereview.chromium.org/1979743002/

Only set one QUIC sending alarm at once.  Flag protected by --quic_only_one_sending_alarm.

Merge internal change: 121700577
https://codereview.chromium.org/1980783002/

Attempts to reduce test flakiness by setting more lenient handshake timeouts. Similar to internal change 121514052.

Merge internal change: 121671674
https://codereview.chromium.org/1978953003/

Reduces flakiness of EndToEndTest.ConnectionMigrationClientPortChanged.

Merge internal change: 121671298
https://codereview.chromium.org/1976393002/

Remove CubicTest::CwndIncreaseStatsDuringConvexRegion because it expects and asserts nothing

Merge internal change: 121638470
https://codereview.chromium.org/1974333004/

Minor clean up of QuicDispatcherTests * Use an actual serialized CHLO instead of "foo" for stream data. * Move all QuicDispatcherTests together, before the QuicDispatcherStatelessRejectTest

Merge internal change: 121604756
https://codereview.chromium.org/1983493002/

Rename various MockConnectionFoo classes to MockQuicConnectionFoo. No behavior change. This is consistent with other Mock classes (e.g. MockQuicDispatcher, MockQuicSpdySession).

Merge internal change: 121596064
https://codereview.chromium.org/1977153002/

Deprecate --quic_stateless_version_negotiation

Merge internal change: 121576119
https://codereview.chromium.org/1975403002/

Deprecate --quic_ignore_invalid_error_code.

Merge internal change: 121437600
https://codereview.chromium.org/1976343002/

Add a new QUIC ChloExtractor class used by the QuicProxyDispatcher to extract CHLO message from packets. protected by --quic_use_chlo_extractor

This CL deprecates QuicPacketParser which allocates a clone of the CryptoHandshakeMessage making it somewhat undesirable for use in "cheap" stateless rejects.

Merge internal change: 121416043
https://codereview.chromium.org/1980663003/

Joins Cookie header components correctly.

A follow-on fix for internal change 121373674. RFC 7540 section 8.1.2.5 specifies that cookie crumbs should be reconstructed with a "; " delimiter.

Merge internal change: 121403250
https://codereview.chromium.org/1974673004/

Deprecate --quic_use_socket_timestamp.

Merge internal change: 121398461
https://codereview.chromium.org/1978913002

Fixes header translation between SpdyHeaderBlock and other data structures. Not protected.

In SPDY, header fields with multiple values are represented in a SpdyHeaderBlock by joining the multiple values together with a null character. This change fixes QUIC-specific utilities that work with SpdyHeaderBlocks.

Merge internal change: 121373674
https://codereview.chromium.org/1976473003/

Add original_path_id to SerializedPacket and OnPacketSent. No functional change expected.

Merge internal change: 121370394
https://codereview.chromium.org/1962643003/

R=rch@chromium.org
BUG=

Committed: https://crrev.com/a7fd124f9bd96195f24fc88c10f953d39cc01936
Cr-Commit-Position: refs/heads/master@{#393750}

[Ryan Hamilton, 2016-05-14 15:48:50]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-05-14 15:48:51]

lgtm

[commit-bot: I haz the power, 2016-05-14 15:49:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979763002/1

[commit-bot: I haz the power, 2016-05-14 20:36:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-14 20:38:13]

Description was changed from

==========
Landing Recent QUIC changes until Sun May 8 00:39:29 2016 +0000
Combine OnCongestionWindowChange and OnRttChange to OnCongestionChange in
QuicSentPacketManager::NetworkChangeVisitor. No functional change expected.

Merge internal change: 121761990
https://codereview.chromium.org/1981643002/

Clean up the pretty-printing of QUIC frames to be internally consistent.

Merge internal change: 121732198
https://codereview.chromium.org/1979633003/

Rename the QUIC stream frame fields frame_buffer and frame_length to data_buffer
and data_length because they do only contain info about the *data* not the full
frame.

Merge internal change: 121705514
https://codereview.chromium.org/1979743002/

Only set one QUIC sending alarm at once.  Flag protected by
--quic_only_one_sending_alarm.

Merge internal change: 121700577
https://codereview.chromium.org/1980783002/

Attempts to reduce test flakiness by setting more lenient handshake timeouts.
Similar to internal change 121514052.

Merge internal change: 121671674
https://codereview.chromium.org/1978953003/

Reduces flakiness of EndToEndTest.ConnectionMigrationClientPortChanged.

Merge internal change: 121671298
https://codereview.chromium.org/1976393002/

Remove CubicTest::CwndIncreaseStatsDuringConvexRegion because it expects and
asserts nothing

Merge internal change: 121638470
https://codereview.chromium.org/1974333004/

Minor clean up of QuicDispatcherTests * Use an actual serialized CHLO instead of
"foo" for stream data. * Move all QuicDispatcherTests together, before the
QuicDispatcherStatelessRejectTest

Merge internal change: 121604756
https://codereview.chromium.org/1983493002/

Rename various MockConnectionFoo classes to MockQuicConnectionFoo. No behavior
change. This is consistent with other Mock classes (e.g. MockQuicDispatcher,
MockQuicSpdySession).

Merge internal change: 121596064
https://codereview.chromium.org/1977153002/

Deprecate --quic_stateless_version_negotiation

Merge internal change: 121576119
https://codereview.chromium.org/1975403002/

Deprecate --quic_ignore_invalid_error_code.

Merge internal change: 121437600
https://codereview.chromium.org/1976343002/

Add a new QUIC ChloExtractor class used by the QuicProxyDispatcher to extract
CHLO message from packets. protected by --quic_use_chlo_extractor

This CL deprecates QuicPacketParser which allocates a clone of the
CryptoHandshakeMessage making it somewhat undesirable for use in "cheap"
stateless rejects.

Merge internal change: 121416043
https://codereview.chromium.org/1980663003/

Joins Cookie header components correctly.

A follow-on fix for internal change 121373674. RFC 7540 section 8.1.2.5
specifies that cookie crumbs should be reconstructed with a "; " delimiter.

Merge internal change: 121403250
https://codereview.chromium.org/1974673004/

Deprecate --quic_use_socket_timestamp.

Merge internal change: 121398461
https://codereview.chromium.org/1978913002

Fixes header translation between SpdyHeaderBlock and other data structures. Not
protected.

In SPDY, header fields with multiple values are represented in a SpdyHeaderBlock
by joining the multiple values together with a null character. This change fixes
QUIC-specific utilities that work with SpdyHeaderBlocks.

Merge internal change: 121373674
https://codereview.chromium.org/1976473003/

Add original_path_id to SerializedPacket and OnPacketSent. No functional change
expected.

Merge internal change: 121370394
https://codereview.chromium.org/1962643003/

R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Sun May 8 00:39:29 2016 +0000
Combine OnCongestionWindowChange and OnRttChange to OnCongestionChange in
QuicSentPacketManager::NetworkChangeVisitor. No functional change expected.

Merge internal change: 121761990
https://codereview.chromium.org/1981643002/

Clean up the pretty-printing of QUIC frames to be internally consistent.

Merge internal change: 121732198
https://codereview.chromium.org/1979633003/

Rename the QUIC stream frame fields frame_buffer and frame_length to data_buffer
and data_length because they do only contain info about the *data* not the full
frame.

Merge internal change: 121705514
https://codereview.chromium.org/1979743002/

Only set one QUIC sending alarm at once.  Flag protected by
--quic_only_one_sending_alarm.

Merge internal change: 121700577
https://codereview.chromium.org/1980783002/

Attempts to reduce test flakiness by setting more lenient handshake timeouts.
Similar to internal change 121514052.

Merge internal change: 121671674
https://codereview.chromium.org/1978953003/

Reduces flakiness of EndToEndTest.ConnectionMigrationClientPortChanged.

Merge internal change: 121671298
https://codereview.chromium.org/1976393002/

Remove CubicTest::CwndIncreaseStatsDuringConvexRegion because it expects and
asserts nothing

Merge internal change: 121638470
https://codereview.chromium.org/1974333004/

Minor clean up of QuicDispatcherTests * Use an actual serialized CHLO instead of
"foo" for stream data. * Move all QuicDispatcherTests together, before the
QuicDispatcherStatelessRejectTest

Merge internal change: 121604756
https://codereview.chromium.org/1983493002/

Rename various MockConnectionFoo classes to MockQuicConnectionFoo. No behavior
change. This is consistent with other Mock classes (e.g. MockQuicDispatcher,
MockQuicSpdySession).

Merge internal change: 121596064
https://codereview.chromium.org/1977153002/

Deprecate --quic_stateless_version_negotiation

Merge internal change: 121576119
https://codereview.chromium.org/1975403002/

Deprecate --quic_ignore_invalid_error_code.

Merge internal change: 121437600
https://codereview.chromium.org/1976343002/

Add a new QUIC ChloExtractor class used by the QuicProxyDispatcher to extract
CHLO message from packets. protected by --quic_use_chlo_extractor

This CL deprecates QuicPacketParser which allocates a clone of the
CryptoHandshakeMessage making it somewhat undesirable for use in "cheap"
stateless rejects.

Merge internal change: 121416043
https://codereview.chromium.org/1980663003/

Joins Cookie header components correctly.

A follow-on fix for internal change 121373674. RFC 7540 section 8.1.2.5
specifies that cookie crumbs should be reconstructed with a "; " delimiter.

Merge internal change: 121403250
https://codereview.chromium.org/1974673004/

Deprecate --quic_use_socket_timestamp.

Merge internal change: 121398461
https://codereview.chromium.org/1978913002

Fixes header translation between SpdyHeaderBlock and other data structures. Not
protected.

In SPDY, header fields with multiple values are represented in a SpdyHeaderBlock
by joining the multiple values together with a null character. This change fixes
QUIC-specific utilities that work with SpdyHeaderBlocks.

Merge internal change: 121373674
https://codereview.chromium.org/1976473003/

Add original_path_id to SerializedPacket and OnPacketSent. No functional change
expected.

Merge internal change: 121370394
https://codereview.chromium.org/1962643003/

R=rch@chromium.org
BUG=

Committed: https://crrev.com/a7fd124f9bd96195f24fc88c10f953d39cc01936
Cr-Commit-Position: refs/heads/master@{#393750}
==========

[commit-bot: I haz the power, 2016-05-14 20:38:14]

Patchset 1 (id:??) landed as
https://crrev.com/a7fd124f9bd96195f24fc88c10f953d39cc01936
Cr-Commit-Position: refs/heads/master@{#393750}