Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979723002: ApplicationConnection devolution, part 3. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 3. Make ApplicationDelegate::ConfigureIncomingConnection() take a ServiceProviderImpl* instead of an ApplicationConnection*. (Maybe it should also be renamed, but we'll leave that battle for another day.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/22e78b3f728e8b9e937d8222ac47c6b2f161b1f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -204 lines) Patch
M examples/apptest/example_service_application.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/apptest/example_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/bank_app/bank.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M examples/echo/README.md View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo/echo_server.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M examples/echo_terminal/main.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M examples/forwarding_content_handler/forwarding_content_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M examples/hello_mojo/hello_mojo_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/indirect_service/indirect_integer_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/indirect_service/integer_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/media_test/media_test_app.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M examples/native_run_app/native_run_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/trace_me/trace_me_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/application_delegate.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application_delegate.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/ui/content_viewer_app.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/ui/content_viewer_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/ui/view_provider_app.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/ui/view_provider_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/asset_bundle/main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.cc View 1 chunk +13 lines, -14 lines 0 comments Download
M services/authentication/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/clipboard/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M services/debugger/debugger.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M services/device_info/device_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/files/main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/gfx/compositor/compositor_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/compositor_app.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M services/http_server/http_server_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/icu_data/icu_data_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/java_handler/java_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M services/java_handler/java_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/js/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/keyboard/linux/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/log/main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/media/audio/audio_server_app.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/media/audio/audio_server_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/factory_service/factory_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/media/factory_service/factory_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/nacl/nonsfi/content_handler_main_nexe.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/nacl/nonsfi/content_handler_main_pexe.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/nacl/nonsfi/pnacl_compile.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/nacl/nonsfi/pnacl_link.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/nacl/sfi/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_support/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_viewport/app_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/app_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/native_viewport/ozone/app_delegate_ozone.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/native_viewport/ozone/app_delegate_ozone.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/prediction/prediction_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/prediction_service_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/python/content_handler/content_handler_main.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M services/test_service/test_request_tracker_application.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/test_service/test_service_application.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/test_service/test_service_application.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/tracing/tracing_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/tracing_app.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/input_manager/input_manager_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_manager/input_manager_app.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M services/ui/launcher/launcher_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/launcher/launcher_app.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M services/ui/view_manager/view_manager_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/view_manager/view_manager_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/android_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/android/native_viewport_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/native_viewport_application_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M shell/test/pingable_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-13 22:17:47 UTC) #1
vardhan
sick (lgtm). disclosure: i mostly only looked at mojo/public/.. and a few other random files, ...
4 years, 7 months ago (2016-05-13 22:22:17 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-13 22:27:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
22e78b3f728e8b9e937d8222ac47c6b2f161b1f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698