Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1979693002: [MD settings] removing .css files from internet settings (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] removing .css files from internet settings This CL moves the contents of the .css files in the Internet settings into the .html files. This removes the deprecated import of .css files in those .html file. BUG=521040 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/775bd818e9c5f0ecdf339d9db5193b402859d538 Cr-Commit-Position: refs/heads/master@{#393899}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -341 lines) Patch
D chrome/browser/resources/settings/internet_page/internet_detail_page.css View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 chunk +51 lines, -2 lines 0 comments Download
D chrome/browser/resources/settings/internet_page/internet_known_networks_page.css View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.html View 1 chunk +20 lines, -2 lines 0 comments Download
D chrome/browser/resources/settings/internet_page/network_apnlist.css View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_apnlist.html View 1 chunk +18 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_ip_config.css View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.html View 1 chunk +9 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_nameservers.css View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.html View 1 chunk +13 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_property_list.css View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 1 chunk +27 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_proxy.css View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 1 chunk +30 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_proxy_exclusions.css View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html View 1 chunk +16 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_proxy_input.css View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_input.html View 1 chunk +13 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_siminfo.css View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 1 chunk +45 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/internet_page/network_summary_item.css View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 chunk +31 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 3 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dschuyler
This CL intentionally doesn't make changes other than moving the code. https://codereview.chromium.org/1979693002/diff/1/chrome/browser/resources/settings/internet_page/network_proxy.html File chrome/browser/resources/settings/internet_page/network_proxy.html (right): ...
4 years, 7 months ago (2016-05-13 20:51:49 UTC) #3
stevenjb
RS LGTM
4 years, 7 months ago (2016-05-16 16:24:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979693002/20001
4 years, 7 months ago (2016-05-16 19:27:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 19:35:22 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 19:37:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/775bd818e9c5f0ecdf339d9db5193b402859d538
Cr-Commit-Position: refs/heads/master@{#393899}

Powered by Google App Engine
This is Rietveld 408576698