device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h - Issue 1979633004: Invoke GattDiscoveryCompleteForService by observing ServicesResolved property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h

Issue 1979633004: Invoke GattDiscoveryCompleteForService by observing ServicesResolved property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_attr

Patch Set: Invoke GattDiscoveryCompleteForService for each GATT service once Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc ('K') | « device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc ('k') | device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h

diff --git a/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h b/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h

index 46192a794da576c8a0128af55ae63fd842cfb198..e19439242de9020c4e26225f28475fca73b20116 100644

--- a/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h

+++ b/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h

@@ -6,6 +6,7 @@

#define DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_REMOTE_GATT_SERVICE_BLUEZ_H_

#include <stdint.h>

rkc 2016/05/16 16:25:23 Nit: Remove extra line.

Miao 2016/05/17 00:22:47 This extra line is for separating the C and C++ li

#include <map>

#include <string>

#include <vector>

@@ -111,10 +112,6 @@ class BluetoothRemoteGattServiceBlueZ

// characteristics by identifier.

CharacteristicMap characteristics_;

- // Indicates whether or not the characteristics of this service are known to

- // have been discovered.

- bool discovery_complete_;

// Note: This should remain the last member so it'll be destroyed and

// invalidate its weak pointers before any other members are destroyed.

base::WeakPtrFactory<BluetoothRemoteGattServiceBlueZ> weak_ptr_factory_;