device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc - Issue 1979633004: Invoke GattDiscoveryCompleteForService by observing ServicesResolved property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

Issue 1979633004: Invoke GattDiscoveryCompleteForService by observing ServicesResolved property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_attr

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h ('k') | device/bluetooth/dbus/fake_bluetooth_device_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

diff --git a/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc b/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

index 60313881991a1fb33d086d5931dbecc2a1e56312..50786999f1a37aa11a18e6e7c85b933263ec2af0 100644

--- a/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

+++ b/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

@@ -22,7 +22,6 @@ BluetoothRemoteGattServiceBlueZ::BluetoothRemoteGattServiceBlueZ(

const dbus::ObjectPath& object_path)

: BluetoothGattServiceBlueZ(adapter, object_path),

device_(device),

- discovery_complete_(false),

weak_ptr_factory_(this) {

VLOG(1) << "Creating remote GATT service with identifier: "

<< object_path.value();

@@ -118,7 +117,7 @@ void BluetoothRemoteGattServiceBlueZ::NotifyServiceChanged() {

// Don't send service changed unless we know that all characteristics have

// already been discovered. This is to prevent spammy events before sending

// out the first Gatt

- if (!discovery_complete_)

+ if (!device_->IsGattServicesDiscoveryComplete())

return;

DCHECK(GetAdapter());