Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1979633002: Add immediate variants of core page load metric histograms. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@firstmetrics
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add immediate variants of core page load metric histograms. BUG=611811 Committed: https://crrev.com/5f481ec582761cec96089b8520e00bb70db14798 Cr-Commit-Position: refs/heads/master@{#394050}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -19 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 1 1 chunk +25 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 1 2 3 6 chunks +176 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 15 chunks +160 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Bryan McQuade
PTAL. This adds a bunch of histograms, but I want to make sure we have ...
4 years, 7 months ago (2016-05-13 18:27:15 UTC) #3
Charlie Harrison
Looks ok, but I'm wondering about the histogram naming. AFAIK the plan is to evaluate ...
4 years, 7 months ago (2016-05-13 20:07:55 UTC) #4
Bryan McQuade
On 2016/05/13 at 20:07:55, csharrison wrote: > Looks ok, but I'm wondering about the histogram ...
4 years, 7 months ago (2016-05-16 01:16:53 UTC) #5
Bryan McQuade
On 2016/05/16 at 01:16:53, Bryan McQuade wrote: > On 2016/05/13 at 20:07:55, csharrison wrote: > ...
4 years, 7 months ago (2016-05-16 01:34:10 UTC) #6
Charlie Harrison
lgtm good idea.
4 years, 7 months ago (2016-05-16 22:18:20 UTC) #7
Bryan McQuade
rkaplow, PTAL for new metric names.
4 years, 7 months ago (2016-05-17 01:28:19 UTC) #9
rkaplow
lgtm sweet
4 years, 7 months ago (2016-05-17 01:49:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979633002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979633002/80001
4 years, 7 months ago (2016-05-17 03:18:21 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-17 04:41:10 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 04:42:14 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5f481ec582761cec96089b8520e00bb70db14798
Cr-Commit-Position: refs/heads/master@{#394050}

Powered by Google App Engine
This is Rietveld 408576698