Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 197963003: Change top-level PRESUBMIT to support split tryserver (Closed)

Created:
6 years, 9 months ago by Paweł Hajdan Jr.
Modified:
6 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Change top-level PRESUBMIT to support split tryserver This also fixes problems with generic trybots not being triggered when other presubmit files which already support multiple masters get in scope. BUG=334892 R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M PRESUBMIT.py View 5 chunks +20 lines, -11 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
6 years, 9 months ago (2014-03-12 22:02:01 UTC) #1
M-A Ruel
lgtm
6 years, 9 months ago (2014-03-12 23:18:42 UTC) #2
Paweł Hajdan Jr.
6 years, 9 months ago (2014-03-12 23:36:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r256698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698