Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979613002: Use ResolvedAst in constant initializers (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-13 14:33:16 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1979613002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1979613002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart#newcode1191 pkg/compiler/lib/src/compile_time_constants.dart:1191: compiler.resolution.getResolvedAst(constructor.declaration); constructor.declaration.resolvedAst :)
4 years, 7 months ago (2016-05-14 00:26:30 UTC) #3
Johnni Winther
https://codereview.chromium.org/1979613002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1979613002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart#newcode1191 pkg/compiler/lib/src/compile_time_constants.dart:1191: compiler.resolution.getResolvedAst(constructor.declaration); On 2016/05/14 00:26:30, Siggi Cherem (dart-lang) wrote: > ...
4 years, 7 months ago (2016-05-18 10:19:50 UTC) #4
Johnni Winther
4 years, 7 months ago (2016-05-18 10:23:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
627c18a7e7257d6b7051b56b2e206179f2e96180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698