third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 1979603002: [css-grid] Fix behavior of flexible track breadths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 1979603002: [css-grid] Fix behavior of flexible track breadths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New version fixing comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js b/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

index 6f02433575bfbace88ebe02eaa1f743e516fe295..3087cc8eeb2fd9da5c21fae7e3442a0c6f3a899d 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

@@ -64,7 +64,7 @@ testGridDefinitionsSetJSValues("3.1459fr", "2.718fr", "800px", "600px");

testGridDefinitionsSetJSValues("+3fr", "+4fr", "800px", "600px", "3fr", "4fr");

// Flex factor values can be zero.

testGridDefinitionsSetJSValues("0fr", ".0fr", "0px", "0px", "0fr", "0fr");

-testGridDefinitionsSetJSValues("minmax(0fr, 0fr)", "minmax(.0fr, .0fr)", "0px", "0px", "minmax(0fr, 0fr)", "minmax(0fr, 0fr)");

+testGridDefinitionsSetJSValues("minmax(auto, 0fr)", "minmax(auto, .0fr)", "0px", "0px", "minmax(auto, 0fr)", "minmax(auto, 0fr)");

debug("");

debug("Test getting and setting grid-template-columns and grid-template-rows to calc() values through JS");

@@ -95,6 +95,9 @@ testGridDefinitionsSetBadJSValues("calc(16px 30px)", "calc(25px + auto)");

testGridDefinitionsSetBadJSValues("minmax(min-content, calc())", "calc(10%(");

// Forward slash not allowed if not part of a shorthand

testGridDefinitionsSetBadJSValues("10px /", "15px /");

+// Flexible lengths are invalid on the min slot of minmax().

+testGridDefinitionsSetBadJSValues("minmax(0fr, 100px)", "minmax(.0fr, 200px)");

+testGridDefinitionsSetBadJSValues("minmax(1fr, 100px)", "minmax(2.5fr, 200px)");

debug("");

debug("Test setting grid-template-columns and grid-template-rows back to 'none' through JS");