Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 1979603002: [css-grid] Fix behavior of flexible track breadths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New version fixing comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 description('Test that setting and getting grid-template-columns and grid-templa te-rows works as expected'); 1 description('Test that setting and getting grid-template-columns and grid-templa te-rows works as expected');
2 2
3 debug("Test getting grid-template-columns and grid-template-rows set through CSS "); 3 debug("Test getting grid-template-columns and grid-template-rows set through CSS ");
4 testGridDefinitionsValues(document.getElementById("gridWithNoneElement"), "none" , "none"); 4 testGridDefinitionsValues(document.getElementById("gridWithNoneElement"), "none" , "none");
5 testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "10px ", "15px"); 5 testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "10px ", "15px");
6 testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "40 0px", "150px"); 6 testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "40 0px", "150px");
7 testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "0px", "0px"); 7 testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "0px", "0px");
8 testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSizeWit hChildren"), "7px", "11px"); 8 testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSizeWit hChildren"), "7px", "11px");
9 testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "0px", "0px"); 9 testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "0px", "0px");
10 testGridDefinitionsValues(document.getElementById("gridWithAutoWithoutSizeElemen t"), "0px", "0px"); 10 testGridDefinitionsValues(document.getElementById("gridWithAutoWithoutSizeElemen t"), "0px", "0px");
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 testGridDefinitionsSetJSValues("minmax(min-content, max-content)", "minmax(max-c ontent, min-content)", "0px", "0px"); 57 testGridDefinitionsSetJSValues("minmax(min-content, max-content)", "minmax(max-c ontent, min-content)", "0px", "0px");
58 testGridDefinitionsSetJSValues("minmax(auto, max-content)", "minmax(10vw, auto)" , "0px", "80px"); 58 testGridDefinitionsSetJSValues("minmax(auto, max-content)", "minmax(10vw, auto)" , "0px", "80px");
59 // Unit comparison should be case-insensitive. 59 // Unit comparison should be case-insensitive.
60 testGridDefinitionsSetJSValues("3600Fr", "154fR", "800px", "600px", "3600fr", "1 54fr"); 60 testGridDefinitionsSetJSValues("3600Fr", "154fR", "800px", "600px", "3600fr", "1 54fr");
61 // Float values are allowed. 61 // Float values are allowed.
62 testGridDefinitionsSetJSValues("3.1459fr", "2.718fr", "800px", "600px"); 62 testGridDefinitionsSetJSValues("3.1459fr", "2.718fr", "800px", "600px");
63 // A leading '+' is allowed. 63 // A leading '+' is allowed.
64 testGridDefinitionsSetJSValues("+3fr", "+4fr", "800px", "600px", "3fr", "4fr"); 64 testGridDefinitionsSetJSValues("+3fr", "+4fr", "800px", "600px", "3fr", "4fr");
65 // Flex factor values can be zero. 65 // Flex factor values can be zero.
66 testGridDefinitionsSetJSValues("0fr", ".0fr", "0px", "0px", "0fr", "0fr"); 66 testGridDefinitionsSetJSValues("0fr", ".0fr", "0px", "0px", "0fr", "0fr");
67 testGridDefinitionsSetJSValues("minmax(0fr, 0fr)", "minmax(.0fr, .0fr)", "0px", "0px", "minmax(0fr, 0fr)", "minmax(0fr, 0fr)"); 67 testGridDefinitionsSetJSValues("minmax(auto, 0fr)", "minmax(auto, .0fr)", "0px", "0px", "minmax(auto, 0fr)", "minmax(auto, 0fr)");
68 68
69 debug(""); 69 debug("");
70 debug("Test getting and setting grid-template-columns and grid-template-rows to calc() values through JS"); 70 debug("Test getting and setting grid-template-columns and grid-template-rows to calc() values through JS");
71 testGridDefinitionsSetJSValues("calc(150px)", "calc(75px)", "150px", "75px"); 71 testGridDefinitionsSetJSValues("calc(150px)", "calc(75px)", "150px", "75px");
72 testGridDefinitionsSetJSValues("calc(50% - 30px)", "calc(75px + 10%)", "370px", "135px"); 72 testGridDefinitionsSetJSValues("calc(50% - 30px)", "calc(75px + 10%)", "370px", "135px");
73 testGridDefinitionsSetJSValues("minmax(25%, calc(30px))", "minmax(calc(75%), 40p x)", "200px", "450px", "minmax(25%, calc(30px))", "minmax(calc(75%), 40px)"); 73 testGridDefinitionsSetJSValues("minmax(25%, calc(30px))", "minmax(calc(75%), 40p x)", "200px", "450px", "minmax(25%, calc(30px))", "minmax(calc(75%), 40px)");
74 testGridDefinitionsSetJSValues("minmax(10%, calc(30px + 10%))", "minmax(calc(25% - 50px), 200px)", "110px", "200px", "minmax(10%, calc(30px + 10%))", "minmax(ca lc(25% - 50px), 200px)"); 74 testGridDefinitionsSetJSValues("minmax(10%, calc(30px + 10%))", "minmax(calc(25% - 50px), 200px)", "110px", "200px", "minmax(10%, calc(30px + 10%))", "minmax(ca lc(25% - 50px), 200px)");
75 75
76 debug(""); 76 debug("");
77 debug("Test setting grid-template-columns and grid-template-rows to bad values t hrough JS"); 77 debug("Test setting grid-template-columns and grid-template-rows to bad values t hrough JS");
(...skipping 10 matching lines...) Expand all
88 testGridDefinitionsSetBadJSValues(".1 fr", "13 fr"); 88 testGridDefinitionsSetBadJSValues(".1 fr", "13 fr");
89 testGridDefinitionsSetBadJSValues("7.-fr", "-8,0fr"); 89 testGridDefinitionsSetBadJSValues("7.-fr", "-8,0fr");
90 // Negative values are not allowed. 90 // Negative values are not allowed.
91 testGridDefinitionsSetBadJSValues("-1px", "-6em"); 91 testGridDefinitionsSetBadJSValues("-1px", "-6em");
92 testGridDefinitionsSetBadJSValues("minmax(-1%, 32%)", "minmax(2vw, -6em)"); 92 testGridDefinitionsSetBadJSValues("minmax(-1%, 32%)", "minmax(2vw, -6em)");
93 // Invalid expressions with calc 93 // Invalid expressions with calc
94 testGridDefinitionsSetBadJSValues("calc(16px 30px)", "calc(25px + auto)"); 94 testGridDefinitionsSetBadJSValues("calc(16px 30px)", "calc(25px + auto)");
95 testGridDefinitionsSetBadJSValues("minmax(min-content, calc())", "calc(10%("); 95 testGridDefinitionsSetBadJSValues("minmax(min-content, calc())", "calc(10%(");
96 // Forward slash not allowed if not part of a shorthand 96 // Forward slash not allowed if not part of a shorthand
97 testGridDefinitionsSetBadJSValues("10px /", "15px /"); 97 testGridDefinitionsSetBadJSValues("10px /", "15px /");
98 // Flexible lengths are invalid on the min slot of minmax().
99 testGridDefinitionsSetBadJSValues("minmax(0fr, 100px)", "minmax(.0fr, 200px)");
100 testGridDefinitionsSetBadJSValues("minmax(1fr, 100px)", "minmax(2.5fr, 200px)");
98 101
99 debug(""); 102 debug("");
100 debug("Test setting grid-template-columns and grid-template-rows back to 'none' through JS"); 103 debug("Test setting grid-template-columns and grid-template-rows back to 'none' through JS");
101 testGridDefinitionsSetJSValues("18px", "66px"); 104 testGridDefinitionsSetJSValues("18px", "66px");
102 testGridDefinitionsSetJSValues("none", "none"); 105 testGridDefinitionsSetJSValues("none", "none");
103 106
104 function testInherit() 107 function testInherit()
105 { 108 {
106 var parentElement = document.createElement("div"); 109 var parentElement = document.createElement("div");
107 document.body.appendChild(parentElement); 110 document.body.appendChild(parentElement);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 element.style.gridTemplateColumns = "initial"; 142 element.style.gridTemplateColumns = "initial";
140 element.style.gridTemplateRows = "initial"; 143 element.style.gridTemplateRows = "initial";
141 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-colu mns')", "'none'"); 144 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-colu mns')", "'none'");
142 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows ')", "'none'"); 145 shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows ')", "'none'");
143 146
144 document.body.removeChild(element); 147 document.body.removeChild(element);
145 } 148 }
146 debug(""); 149 debug("");
147 debug("Test setting grid-template-columns and grid-template-rows to 'initial' th rough JS"); 150 debug("Test setting grid-template-columns and grid-template-rows to 'initial' th rough JS");
148 testInitial(); 151 testInitial();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698