Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: platform_tools/android/bin/android_make

Issue 19796008: Update android_make to use arrays instead of space delimited strings (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_make
diff --git a/platform_tools/android/bin/android_make b/platform_tools/android/bin/android_make
index da8cf4264a42d24664352213c8fe03b18b768e24..0e6ae5e77da066fb1eddbbbaa570f0db48a34eef 100755
--- a/platform_tools/android/bin/android_make
+++ b/platform_tools/android/bin/android_make
@@ -1,6 +1,5 @@
#!/bin/bash
-makeVars=""
deviceID=""
while (( "$#" )); do
@@ -16,7 +15,7 @@ while (( "$#" )); do
ANDROID_MAKE_CCACHE=$(which ccache)
fi
else
- makeVars="$makeVars $1"
+ makeVars=("${makeVars[@]}" "$1")
fi
shift
@@ -50,7 +49,7 @@ fi
# write the out directory into the .android_config file
echo $SKIA_OUT > .android_config
-make $makeVars
+make ${makeVars[@]}
if [ $? != 0 ]
then
exit 1;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698