Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: ui/message_center/views/notification_view.h

Issue 1979583003: Support notifications with custom content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@messageview-close-button
Patch Set: fix mac build, attempt 2 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/message_view_factory.cc ('k') | ui/message_center/views/notification_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/notification_view.h
diff --git a/ui/message_center/views/notification_view.h b/ui/message_center/views/notification_view.h
index 304475a3fb85e7fb2762ddad06181e76b0399b08..efcba38cf2f146668e16a7324b349fba1ca7f828 100644
--- a/ui/message_center/views/notification_view.h
+++ b/ui/message_center/views/notification_view.h
@@ -25,28 +25,19 @@ class BoundedLabel;
class MessageCenter;
class NotificationButton;
class NotificationProgressBarBase;
-class NotificationView;
class PaddedButton;
class ProportionalImageView;
// View that displays all current types of notification (web, basic, image, and
-// list). Future notification types may be handled by other classes, in which
-// case instances of those classes would be returned by the Create() factory
-// method below.
+// list) except the custom notification. Future notification types may be
+// handled by other classes, in which case instances of those classes would be
+// returned by the Create() factory method below.
class MESSAGE_CENTER_EXPORT NotificationView
: public MessageView,
public views::ViewTargeterDelegate {
public:
- // Creates appropriate MessageViews for notifications. Those currently are
- // always NotificationView instances but in the future
- // may be instances of other classes, with the class depending on the
- // notification type. A notification is top level if it needs to be rendered
- // outside the browser window. No custom shadows are created for top level
- // notifications on Linux with Aura.
- // |controller| may be NULL, but has to be set before the view is shown.
- static MessageView* Create(MessageCenterController* controller,
- const Notification& notification,
- bool top_level);
+ NotificationView(MessageCenterController* controller,
+ const Notification& notification);
~NotificationView() override;
// Overridden from views::View:
@@ -61,10 +52,6 @@ class MESSAGE_CENTER_EXPORT NotificationView
void UpdateWithNotification(const Notification& notification) override;
void ButtonPressed(views::Button* sender, const ui::Event& event) override;
- protected:
- NotificationView(MessageCenterController* controller,
- const Notification& notification);
-
private:
FRIEND_TEST_ALL_PREFIXES(NotificationViewTest, CreateOrUpdateTest);
FRIEND_TEST_ALL_PREFIXES(NotificationViewTest,
« no previous file with comments | « ui/message_center/views/message_view_factory.cc ('k') | ui/message_center/views/notification_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698