ui/message_center/views/message_center_view.cc - Issue 1979583003: Support notifications with custom content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/message_center_view.cc

Issue 1979583003: Support notifications with custom content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@messageview-close-button

Patch Set: fix mac build, attempt 2 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/message_center/views/custom_notification_view_unittest.cc ('k') | ui/message_center/views/message_popup_collection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/message_center/views/message_center_view.cc

diff --git a/ui/message_center/views/message_center_view.cc b/ui/message_center/views/message_center_view.cc

index aa04936b10a7a3d68600febab84f43685d821e0c..a82de8e9d8de7e032d17e4a4bd78ed45eeebe671 100644

--- a/ui/message_center/views/message_center_view.cc

+++ b/ui/message_center/views/message_center_view.cc

@@ -26,7 +26,7 @@

#include "ui/message_center/views/message_list_view.h"

#include "ui/message_center/views/message_view.h"

#include "ui/message_center/views/message_view_context_menu_controller.h"

-#include "ui/message_center/views/notification_view.h"

+#include "ui/message_center/views/message_view_factory.h"

#include "ui/message_center/views/notifier_settings_view.h"

#include "ui/resources/grit/ui_resources.h"

#include "ui/strings/grit/ui_strings.h"

@@ -480,7 +480,7 @@ void MessageCenterView::AnimationCanceled(const gfx::Animation* animation) {

void MessageCenterView::AddNotificationAt(const Notification& notification,

int index) {

MessageView* view =

- NotificationView::Create(this, notification, false); // Not top-level.

+ MessageViewFactory::Create(this, notification, false); // Not top-level.

view->set_context_menu_controller(context_menu_controller_.get());

notification_views_[notification.id()] = view;

view->set_scroller(scroller_);