Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1531)

Issue 1979553003: Consolidate to use MessageView (Closed)

Created:
4 years, 7 months ago by xiyuan
Modified:
4 years, 7 months ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate to use MessageView - Make factory NotificationView::Create to return MessageView* instead of NotificationView*; - Use MessageView in MessageCenterView and MessagePopupCollection; - Remove MessageViewController and replace it with MessageCenterController; BUG=610767 Committed: https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d Cr-Commit-Position: refs/heads/master@{#393663}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -59 lines) Patch
M ui/message_center/views/message_center_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_view.h View 3 chunks +8 lines, -10 lines 0 comments Download
M ui/message_center/views/message_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/message_center/views/notification_view.h View 5 chunks +4 lines, -17 lines 2 comments Download
M ui/message_center/views/notification_view.cc View 5 chunks +8 lines, -18 lines 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
xiyuan
First part of the custom notification support CL. Split so that it is more readable. ...
4 years, 7 months ago (2016-05-13 19:45:09 UTC) #2
dewittj
lgtm with a nit https://codereview.chromium.org/1979553003/diff/1/ui/message_center/views/notification_view.h File ui/message_center/views/notification_view.h (right): https://codereview.chromium.org/1979553003/diff/1/ui/message_center/views/notification_view.h#newcode47 ui/message_center/views/notification_view.h:47: static MessageView* Create(MessageCenterController* controller, Is ...
4 years, 7 months ago (2016-05-13 20:24:32 UTC) #3
xiyuan
https://codereview.chromium.org/1979553003/diff/1/ui/message_center/views/notification_view.h File ui/message_center/views/notification_view.h (right): https://codereview.chromium.org/1979553003/diff/1/ui/message_center/views/notification_view.h#newcode47 ui/message_center/views/notification_view.h:47: static MessageView* Create(MessageCenterController* controller, On 2016/05/13 20:24:32, dewittj wrote: ...
4 years, 7 months ago (2016-05-13 21:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979553003/1
4 years, 7 months ago (2016-05-13 22:20:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 22:24:53 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:26:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d
Cr-Commit-Position: refs/heads/master@{#393663}

Powered by Google App Engine
This is Rietveld 408576698