Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: ipc/attachment_broker_privileged.h

Issue 1979533003: Fix an attachment broker race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/attachment_broker.cc ('k') | ipc/attachment_broker_privileged_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/attachment_broker_privileged.h
diff --git a/ipc/attachment_broker_privileged.h b/ipc/attachment_broker_privileged.h
index 8be24ac03e879fb3bdcefc12ab87a061ac816263..36069c11f394c2152f2a8fe003eea0a577d76543 100644
--- a/ipc/attachment_broker_privileged.h
+++ b/ipc/attachment_broker_privileged.h
@@ -71,7 +71,7 @@ class IPC_EXPORT AttachmentBrokerPrivileged : public IPC::AttachmentBroker {
void SendMessageToEndpoint(EndpointRunnerPair pair, Message* message);
// Errors that can be reported by subclasses.
- // These match tools/metrics/histograms.xml.
+ // These match tools/metrics/histograms/histograms.xml.
// This enum is append-only.
enum UMAError {
// The brokerable attachment had a valid destination. This is the success
@@ -108,6 +108,10 @@ class IPC_EXPORT AttachmentBrokerPrivileged : public IPC::AttachmentBroker {
ERROR_COULD_NOT_OPEN_SOURCE_OR_DEST = 13,
// The broker was asked to transfer a HANDLE with invalid permissions.
ERROR_INVALID_PERMISSIONS = 14,
+ // The broker was not immediately able to send an attachment.
+ DELAYED = 15,
+ // The broker successfully sent a delayed attachment.
+ DELAYED_SEND = 16,
ERROR_MAX
};
« no previous file with comments | « ipc/attachment_broker.cc ('k') | ipc/attachment_broker_privileged_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698