Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: ipc/attachment_broker.cc

Issue 1979533003: Fix an attachment broker race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/attachment_broker.h ('k') | ipc/attachment_broker_privileged.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/attachment_broker.h" 5 #include "ipc/attachment_broker.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 93
94 void AttachmentBroker::RegisterBrokerCommunicationChannel(Endpoint* endpoint) { 94 void AttachmentBroker::RegisterBrokerCommunicationChannel(Endpoint* endpoint) {
95 NOTREACHED(); 95 NOTREACHED();
96 } 96 }
97 97
98 void AttachmentBroker::DeregisterBrokerCommunicationChannel( 98 void AttachmentBroker::DeregisterBrokerCommunicationChannel(
99 Endpoint* endpoint) { 99 Endpoint* endpoint) {
100 NOTREACHED(); 100 NOTREACHED();
101 } 101 }
102 102
103 void AttachmentBroker::ReceivedPeerPid(base::ProcessId peer_pid) {
104 NOTREACHED();
105 }
106
103 bool AttachmentBroker::IsPrivilegedBroker() { 107 bool AttachmentBroker::IsPrivilegedBroker() {
104 NOTREACHED(); 108 NOTREACHED();
105 return false; 109 return false;
106 } 110 }
107 111
108 void AttachmentBroker::HandleReceivedAttachment( 112 void AttachmentBroker::HandleReceivedAttachment(
109 const scoped_refptr<BrokerableAttachment>& attachment) { 113 const scoped_refptr<BrokerableAttachment>& attachment) {
110 { 114 {
111 base::AutoLock auto_lock(*get_lock()); 115 base::AutoLock auto_lock(*get_lock());
112 attachments_.push_back(attachment); 116 attachments_.push_back(attachment);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 152
149 observer->ReceivedBrokerableAttachmentWithId(id); 153 observer->ReceivedBrokerableAttachmentWithId(id);
150 } 154 }
151 155
152 AttachmentBroker::ObserverInfo::ObserverInfo() {} 156 AttachmentBroker::ObserverInfo::ObserverInfo() {}
153 AttachmentBroker::ObserverInfo::ObserverInfo(const ObserverInfo& other) = 157 AttachmentBroker::ObserverInfo::ObserverInfo(const ObserverInfo& other) =
154 default; 158 default;
155 AttachmentBroker::ObserverInfo::~ObserverInfo() {} 159 AttachmentBroker::ObserverInfo::~ObserverInfo() {}
156 160
157 } // namespace IPC 161 } // namespace IPC
OLDNEW
« no previous file with comments | « ipc/attachment_broker.h ('k') | ipc/attachment_broker_privileged.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698