src/compiler/bytecode-graph-builder.cc - Issue 1979523002: [interpreter] Remove BytecodeArrayBuilder::Illegal().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1979523002: [interpreter] Remove BytecodeArrayBuilder::Illegal(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 513d3e0703891293d676376dff812a37a835a003..2c2ec998d72dacb93c13b79a3eb29d5fc5b0ab8b 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -1419,8 +1419,8 @@ void BytecodeGraphBuilder::VisitExtraWide() {

}

void BytecodeGraphBuilder::VisitIllegal() {

- NewNode(javascript()->CallRuntime(Runtime::kAbort),

- jsgraph()->Constant(kIllegalBytecode));

+ // Not emitted in valid bytecode.

+ UNREACHABLE();

}

void BytecodeGraphBuilder::VisitNop() {}

« no previous file with comments | « src/bailout-reason.h ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »