src/interpreter/bytecode-array-writer.cc - Issue 1979523002: [interpreter] Remove BytecodeArrayBuilder::Illegal().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-writer.cc

Issue 1979523002: [interpreter] Remove BytecodeArrayBuilder::Illegal(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Abort would be better :-D Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-array-writer.cc

diff --git a/src/interpreter/bytecode-array-writer.cc b/src/interpreter/bytecode-array-writer.cc

index 17d1aedfc698f25613581e61bf8fced5cd5080e0..029688ea58f4ec60e489c45743983a781fcf649b 100644

--- a/src/interpreter/bytecode-array-writer.cc

+++ b/src/interpreter/bytecode-array-writer.cc

@@ -41,6 +41,8 @@ void BytecodeArrayWriter::UpdateSourcePositionTable(

}

void BytecodeArrayWriter::EmitBytecode(const BytecodeNode* const node) {

+ DCHECK_NE(node->bytecode(), Bytecode::kIllegal);

OperandScale operand_scale = node->operand_scale();

if (operand_scale != OperandScale::kSingle) {

Bytecode prefix = Bytecodes::OperandScaleToPrefixBytecode(operand_scale);