Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: src/log.h

Issue 19795002: Logger: extract CodeEventLogger classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 285d8734ba0e1d602f86f086d46df26090ab5977..e86566b3a7b4fc5042979367daace0814a73c800 100644
--- a/src/log.h
+++ b/src/log.h
@@ -70,6 +70,7 @@ namespace internal {
// tick profiler requires code events, so --prof implies --log-code.
// Forward declarations.
+class CodeAddressMap;
class CompilationInfo;
class CpuProfiler;
class Isolate;
@@ -373,9 +374,6 @@ class Logger {
void LogFailure();
private:
- class NameBuffer;
- class NameMap;
-
explicit Logger(Isolate* isolate);
~Logger();
@@ -402,14 +400,6 @@ class Logger {
// Helper method. It resets name_buffer_ and add tag name into it.
void InitNameBuffer(LogEventsAndTags tag);
- // Helper method. It push recorded buffer into different handlers.
- void LogRecordedBuffer(Code*, SharedFunctionInfo*);
-
- // Helper method. It dumps name into name_buffer_.
- void AppendName(Name* name);
-
- void RegisterSnapshotCodeName(Code* code, const char* name, int name_size);
-
// Emits a profiler tick event. Used by the profiler thread.
void TickEvent(TickSample* sample, bool overflow);
@@ -452,10 +442,7 @@ class Logger {
Log* log_;
LowLevelLogger* ll_logger_;
JitLogger* jit_logger_;
-
- NameBuffer* name_buffer_;
-
- NameMap* address_to_name_map_;
+ CodeAddressMap* code_address_map_;
// Guards against multiple calls to TearDown() that can happen in some tests.
// 'true' between SetUp() and TearDown().
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698