Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979473003: Version 5.1.281.35 (cherry-pick) (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.35 (cherry-pick) Merged 04c8c11ee569a41d4b07839154eb0c718ff6e381 Make array __proto__ manipulations not disturb the species protector BUG=chromium:606207 LOG=N R=adamk@chromium.org, adamk Committed: https://chromium.googlesource.com/v8/v8/+/b4d8d3e360efefc541f406c1cba0499396b2f55c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -24 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +1 line, -11 lines 0 comments Download
M src/objects-inl.h View 3 chunks +6 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/array-species-constructor.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/array-species-constructor-accessor.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/array-species-constructor-delete.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/array-species-delete.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/array-species-modified.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/array-species-parent-constructor.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/array-species-proto.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Dan Ehrenberg
4 years, 7 months ago (2016-05-13 17:54:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979473003/1
4 years, 7 months ago (2016-05-13 18:08:24 UTC) #3
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 7 months ago (2016-05-13 18:08:26 UTC) #5
adamk
lgtm
4 years, 7 months ago (2016-05-13 18:09:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979473003/1
4 years, 7 months ago (2016-05-13 18:18:34 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-13 18:18:36 UTC) #10
Dan Ehrenberg
4 years, 7 months ago (2016-05-13 18:22:02 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b4d8d3e360efefc541f406c1cba0499396b2f55c.

Powered by Google App Engine
This is Rietveld 408576698