Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1979463002: Move some classes out of doc_vt.cpp into their own files. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move some classes out of doc_vt.cpp into their own files. Committed: https://pdfium.googlesource.com/pdfium/+/9c845c3117bf09191e83e9108e98a82fb1051075

Patch Set 1 : Move CSection into its own file. #

Patch Set 2 : Move CTypeset into its own file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -1131 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A core/fpdfdoc/csection.cpp View 1 chunk +290 lines, -0 lines 0 comments Download
A + core/fpdfdoc/ctypeset.cpp View 1 9 chunks +122 lines, -395 lines 0 comments Download
M core/fpdfdoc/doc_vt.cpp View 1 2 chunks +0 lines, -736 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
Just shuffling code.
4 years, 7 months ago (2016-05-13 05:36:30 UTC) #6
Wei Li
lgtm
4 years, 7 months ago (2016-05-13 16:50:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979463002/80001
4 years, 7 months ago (2016-05-13 17:50:33 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:08:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/9c845c3117bf09191e83e9108e98a82fb105...

Powered by Google App Engine
This is Rietveld 408576698