Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1979433002: Remove page_cycler.morejs benchmark & morejs pageset (Closed)

Created:
4 years, 7 months ago by nednguyen
Modified:
4 years, 7 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, telemetry-reviews_chromium.org, dtu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove page_cycler.morejs benchmark & morejs pageset BUG=606277, 611484 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/89829b85f836e164584ecf88d9de8584427eb13d Cr-Commit-Position: refs/heads/master@{#393466}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/perf/page_sets/page_cycler/morejs.py View 1 chunk +0 lines, -36 lines 1 comment Download
D tools/perf/page_sets/page_cycler/morejsnp.py View 1 chunk +0 lines, -38 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
nednguyen
4 years, 7 months ago (2016-05-13 03:51:14 UTC) #3
kouhei (in TOK)
lgtm
4 years, 7 months ago (2016-05-13 03:51:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979433002/1
4 years, 7 months ago (2016-05-13 03:51:54 UTC) #6
nednguyen
https://codereview.chromium.org/1979433002/diff/1/tools/perf/page_sets/page_cycler/morejs.py File tools/perf/page_sets/page_cycler/morejs.py (left): https://codereview.chromium.org/1979433002/diff/1/tools/perf/page_sets/page_cycler/morejs.py#oldcode13 tools/perf/page_sets/page_cycler/morejs.py:13: class MorejsPageSet(story.StorySet): Only used by page_cycler.morejs: https://code.google.com/p/chromium/codesearch#search/&q=MorejsPageSet&sq=package:chromium&type=cs https://codereview.chromium.org/1979433002/diff/1/tools/perf/page_sets/page_cycler/morejsnp.py File ...
4 years, 7 months ago (2016-05-13 03:52:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 07:54:36 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 07:55:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89829b85f836e164584ecf88d9de8584427eb13d
Cr-Commit-Position: refs/heads/master@{#393466}

Powered by Google App Engine
This is Rietveld 408576698