mash: Initialize ash::MaterialDesignController on startup

mash: Initialize ash::MaterialDesignController on startup

Fixes a DCHECK failure on start.

BUG=none
TEST=mash starts normally in debug
TBR=sky@chromium.org

Committed: https://crrev.com/ca7e96aa77e858d7a8b1573f0a21c3f1ca86f292
Cr-Commit-Position: refs/heads/master@{#393955}

[msw, 2016-05-16 21:29:43]

msw@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-05-16 21:29:43]

lgtm with a nit/q.

https://codereview.chromium.org/1979393003/diff/1/ash/mus/sysui_application.cc
File ash/mus/sysui_application.cc (right):

https://codereview.chromium.org/1979393003/diff/1/ash/mus/sysui_application.c...
ash/mus/sysui_application.cc:202: ash::MaterialDesignController::Initialize();
nit: perhaps also call ui::MaterialDesignController::Initialize()?

[James Cook, 2016-05-16 21:32:19]

https://codereview.chromium.org/1979393003/diff/1/ash/mus/sysui_application.cc
File ash/mus/sysui_application.cc (right):

https://codereview.chromium.org/1979393003/diff/1/ash/mus/sysui_application.c...
ash/mus/sysui_application.cc:202: ash::MaterialDesignController::Initialize();
On 2016/05/16 21:29:43, msw wrote:
> nit: perhaps also call ui::MaterialDesignController::Initialize()?

ui::MaterialDesignController::Initialize() is done as part of views::AuraInit
construction on the line above. It needs to be done down in //ui for tests, but
the ash init has to happen at a higher level, like Chrome browser main (where it
is done for Chrome) or here.

[James Cook, 2016-05-16 21:32:22]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-05-16 21:32:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979393003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979393003/1

[msw, 2016-05-16 21:34:57]

thanks, lgtm!

https://codereview.chromium.org/1979393003/diff/1/ash/mus/sysui_application.cc
File ash/mus/sysui_application.cc (right):

https://codereview.chromium.org/1979393003/diff/1/ash/mus/sysui_application.c...
ash/mus/sysui_application.cc:202: ash::MaterialDesignController::Initialize();
On 2016/05/16 21:32:18, James Cook wrote:
> On 2016/05/16 21:29:43, msw wrote:
> > nit: perhaps also call ui::MaterialDesignController::Initialize()?
> 
> ui::MaterialDesignController::Initialize() is done as part of views::AuraInit
> construction on the line above. It needs to be done down in //ui for tests,
but
> the ash init has to happen at a higher level, like Chrome browser main (where
it
> is done for Chrome) or here.

Acknowledged.

[commit-bot: I haz the power, 2016-05-16 21:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 21:41:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[James Cook, 2016-05-16 21:45:48]

Description was changed from

==========
mash: Initialize ash::MaterialDesignController on startup

Fixes a DCHECK failure on start.

BUG=none
TEST=mash starts normally in debug
==========

to

==========
mash: Initialize ash::MaterialDesignController on startup

Fixes a DCHECK failure on start.

BUG=none
TEST=mash starts normally in debug
TBR=sky@chromium.org
==========

[James Cook, 2016-05-16 21:45:52]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-05-16 21:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979393003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979393003/1

[commit-bot: I haz the power, 2016-05-16 22:36:01]

Description was changed from

==========
mash: Initialize ash::MaterialDesignController on startup

Fixes a DCHECK failure on start.

BUG=none
TEST=mash starts normally in debug
TBR=sky@chromium.org
==========

to

==========
mash: Initialize ash::MaterialDesignController on startup

Fixes a DCHECK failure on start.

BUG=none
TEST=mash starts normally in debug
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-05-16 22:36:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-16 22:38:16]

Description was changed from

==========
mash: Initialize ash::MaterialDesignController on startup

Fixes a DCHECK failure on start.

BUG=none
TEST=mash starts normally in debug
TBR=sky@chromium.org
==========

to

==========
mash: Initialize ash::MaterialDesignController on startup

Fixes a DCHECK failure on start.

BUG=none
TEST=mash starts normally in debug
TBR=sky@chromium.org

Committed: https://crrev.com/ca7e96aa77e858d7a8b1573f0a21c3f1ca86f292
Cr-Commit-Position: refs/heads/master@{#393955}
==========

[commit-bot: I haz the power, 2016-05-16 22:38:17]

Patchset 1 (id:??) landed as
https://crrev.com/ca7e96aa77e858d7a8b1573f0a21c3f1ca86f292
Cr-Commit-Position: refs/heads/master@{#393955}