Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1979333002: Add a `strong-outputs` mode to build_sdk_summaries.dart. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a `strong-outputs` mode to build_sdk_summaries.dart. This is needed by dev_compiler, which currently has its own fork of the SDK that can only be summarized successfully in strong mode. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/655e9155a8c3c1b022ca6f6f6d69bc3295f02bab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 7 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-16 17:39:46 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-16 17:58:08 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-16 18:29:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
655e9155a8c3c1b022ca6f6f6d69bc3295f02bab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698