Added crnet_framework target to build CrNet dynamic framework.

Added crnet_framework target to build CrNet dynamic framework.

BUG=500975
Committed: https://crrev.com/d1e44cb806479704d87322cb771863404649e1af
Cr-Commit-Position: refs/heads/master@{#395159}

[mef, 2016-05-17 15:25:33]

mef@chromium.org changed reviewers:
+ kapishnikov@chromium.org

[mef, 2016-05-17 15:25:34]

Hi Andrei, PTAL.
This CL is basically applying your cronet_framework target to CrNet.

[kapishnikov, 2016-05-17 20:58:38]

Looks good. LGTM

https://codereview.chromium.org/1979313002/diff/20001/ios/crnet/crnet.gyp
File ios/crnet/crnet.gyp (right):

https://codereview.chromium.org/1979313002/diff/20001/ios/crnet/crnet.gyp#new...
ios/crnet/crnet.gyp:53: # TODO(ellyjones): http://crbug.com/485144
The bug is assigned to me.

https://codereview.chromium.org/1979313002/diff/20001/ios/crnet/crnet.gyp#new...
ios/crnet/crnet.gyp:83: 'crnet_resources',
Do 'crnet_resources' resources appear under "CrNet.framework/Resources"? Just to
double check that they are copied.

[mef, 2016-05-20 19:39:32]

Description was changed from

==========
Added crnet_framework target to build CrNet dynamic framework.

BUG=
==========

to

==========
Added crnet_framework target to build CrNet dynamic framework.

BUG=500975
==========

[mef, 2016-05-20 19:52:46]

Thanks!

https://codereview.chromium.org/1979313002/diff/20001/ios/crnet/crnet.gyp
File ios/crnet/crnet.gyp (right):

https://codereview.chromium.org/1979313002/diff/20001/ios/crnet/crnet.gyp#new...
ios/crnet/crnet.gyp:53: # TODO(ellyjones): http://crbug.com/485144
On 2016/05/17 20:58:37, kapishnikov wrote:
> The bug is assigned to me.

This bug seems to be outdated. Removed.

https://codereview.chromium.org/1979313002/diff/20001/ios/crnet/crnet.gyp#new...
ios/crnet/crnet.gyp:83: 'crnet_resources',
On 2016/05/17 20:58:37, kapishnikov wrote:
> Do 'crnet_resources' resources appear under "CrNet.framework/Resources"? Just
to
> double check that they are copied.

Yes, they do.

[mef, 2016-05-20 19:53:44]

The CQ bit was checked by mef@chromium.org

[mef, 2016-05-20 19:53:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
kapishnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1979313002/#ps40001
(title: "Address Andrei's comments.")

[commit-bot: I haz the power, 2016-05-20 19:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979313002/40001

[commit-bot: I haz the power, 2016-05-20 20:54:13]

Description was changed from

==========
Added crnet_framework target to build CrNet dynamic framework.

BUG=500975
==========

to

==========
Added crnet_framework target to build CrNet dynamic framework.

BUG=500975
==========

[commit-bot: I haz the power, 2016-05-20 20:54:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 20:55:29]

Description was changed from

==========
Added crnet_framework target to build CrNet dynamic framework.

BUG=500975
==========

to

==========
Added crnet_framework target to build CrNet dynamic framework.

BUG=500975

Committed: https://crrev.com/d1e44cb806479704d87322cb771863404649e1af
Cr-Commit-Position: refs/heads/master@{#395159}
==========

[commit-bot: I haz the power, 2016-05-20 20:55:30]

Patchset 3 (id:??) landed as
https://crrev.com/d1e44cb806479704d87322cb771863404649e1af
Cr-Commit-Position: refs/heads/master@{#395159}