Issue 19793011: (upload draf code for backup) pdfviewer: improve memory, son't allocate extra buffers, and put the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19793011: (upload draf code for backup) pdfviewer: improve memory, son't allocate extra buffers, and put the … (Closed)

Created:
7 years, 5 months ago by edisonn

Modified:
7 years, 5 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

pdfviewer: improve memory usage, improve parse time (by 30-50%) and don't allocate extra buffers (more to do, but low priority now), and put the page specific memory in an allocator. Committed: https://code.google.com/p/skia/source/detail?r=10282

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+543 lines, -321 lines)			Patch
M	experimental/PdfViewer/SkPdfBasics.h	View	1 2 3 4 5	3 chunks	+9 lines, -4 lines	0 comments	Download
M	experimental/PdfViewer/SkPdfBasics.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	experimental/PdfViewer/SkPdfConfig.h	View	1 2 3 4 5	2 chunks	+21 lines, -0 lines	0 comments	Download
M	experimental/PdfViewer/SkPdfFont.cpp	View	1 2 3 4 5	2 chunks	+5 lines, -3 lines	0 comments	Download
M	experimental/PdfViewer/SkPdfRenderer.cpp	View	1 2 3 4 5	20 chunks	+136 lines, -108 lines	0 comments	Download
M	experimental/PdfViewer/pdf_viewer_main.cpp	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.h	View	1 2 3 4 5	4 chunks	+8 lines, -9 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp	View	1 2 3 4 5	16 chunks	+48 lines, -34 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.h	View	1 2 3 4 5	4 chunks	+8 lines, -8 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp	View	1 2 3 4 5	27 chunks	+216 lines, -96 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfObject.h	View	1 2 3 4 5	17 chunks	+58 lines, -41 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfObject.cpp	View	1 2 3 4 5	4 chunks	+21 lines, -18 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

edisonn

7 years, 5 months ago (2013-07-23 17:43:22 UTC) #1

Message was sent while issue was closed.

Committed patchset #7 manually as r10282 (presubmit successful).

Expand Messages | Collapse Messages