Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 19793005: Turn ToNumberStub into a hydrogen code stub. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Turn ToNumberStub into a hydrogen code stub. R=danno@chromium.org, hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -100 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +10 lines, -27 lines 0 comments Download
M src/code-stubs.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +10 lines, -21 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +10 lines, -28 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +10 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-20 05:48:02 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 5 months ago (2013-07-22 17:04:44 UTC) #2
danno
+1 to the lgtm. I like this change a lot. A cool follow on: we ...
7 years, 5 months ago (2013-07-22 21:26:34 UTC) #3
Benedikt Meurer
7 years, 5 months ago (2013-07-23 06:03:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698