Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979273003: Added logs when contacting Blimp assigner (Closed)

Created:
4 years, 7 months ago by shaktisahu
Modified:
4 years, 7 months ago
Reviewers:
Kevin M
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added logs when contacting Blimp assigner To help in debugging, I added a few logs in BlimpClientSession related to assignment. BUG=601127 Committed: https://crrev.com/0168fd42c7ad59e7efa369efbbbe0020f050683c Cr-Commit-Position: refs/heads/master@{#393984}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M blimp/client/session/blimp_client_session.cc View 2 chunks +4 lines, -1 line 2 comments Download

Messages

Total messages: 10 (3 generated)
shaktisahu
4 years, 7 months ago (2016-05-16 17:48:39 UTC) #2
Kevin M
https://codereview.chromium.org/1979273003/diff/1/blimp/client/session/blimp_client_session.cc File blimp/client/session/blimp_client_session.cc (right): https://codereview.chromium.org/1979273003/diff/1/blimp/client/session/blimp_client_session.cc#newcode209 blimp/client/session/blimp_client_session.cc:209: VLOG(1) << "Assignment succeeded"; Add detail for the fields ...
4 years, 7 months ago (2016-05-16 17:56:32 UTC) #3
shaktisahu
https://codereview.chromium.org/1979273003/diff/1/blimp/client/session/blimp_client_session.cc File blimp/client/session/blimp_client_session.cc (right): https://codereview.chromium.org/1979273003/diff/1/blimp/client/session/blimp_client_session.cc#newcode209 blimp/client/session/blimp_client_session.cc:209: VLOG(1) << "Assignment succeeded"; On 2016/05/16 17:56:32, Kevin M ...
4 years, 7 months ago (2016-05-16 18:10:29 UTC) #4
Kevin M
lgtm
4 years, 7 months ago (2016-05-16 22:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979273003/1
4 years, 7 months ago (2016-05-16 22:53:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 23:49:49 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 23:52:26 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0168fd42c7ad59e7efa369efbbbe0020f050683c
Cr-Commit-Position: refs/heads/master@{#393984}

Powered by Google App Engine
This is Rietveld 408576698