cc: Use to_screen transform for scroll offset snapping

cc: Use to_screen transform for scroll offset snapping

As part of the process of cleaning up transform tree logic, target
space transform is not going to live in the transform tree, so scroll
snapping has to snap screen space transform instead.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d0d98d0dcf5e3758a604f4c5e61a75166b0e57f7
Cr-Commit-Position: refs/heads/master@{#394245}

[sunxd, 2016-05-16 15:22:17]

Description was changed from

==========
cc: Use to_screen transform for scroll offset snapping.

BUG=597721
==========

to

==========
cc: Use to_screen transform for scroll offset snapping.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-05-17 18:18:25]

Description was changed from

==========
cc: Use to_screen transform for scroll offset snapping.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use to_screen transform for scroll offset snapping

As part of the process of cleaning up transform tree logic, target
space transform is not going to live in the transform tree, so scroll
snapping has to snap screen space transform instead.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-05-17 18:18:25]

sunxd@chromium.org changed reviewers:
+ ajuma@chromium.org, jaydasika@chromium.org, vollick@chromium.org,
weiliangc@chromium.org

[sunxd, 2016-05-17 18:19:46]

https://codereview.chromium.org/1979273002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_scroll.cc (right):

https://codereview.chromium.org/1979273002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_scroll.cc:530: EXPECT_EQ(translate,
I'm not sure if there is a better variable to compare here.

[ajuma, 2016-05-17 19:18:51]

lgtm

https://codereview.chromium.org/1979273002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_scroll.cc (right):

https://codereview.chromium.org/1979273002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_scroll.cc:530: EXPECT_EQ(translate,
On 2016/05/17 18:19:45, sunxd wrote:
> I'm not sure if there is a better variable to compare here.

You could compare to the identity (either by comparing to gfx::Transform(), or
by checking if screen_space_transform.IsIdentity is true).

[sunxd, 2016-05-17 19:38:02]

https://codereview.chromium.org/1979273002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_scroll.cc (right):

https://codereview.chromium.org/1979273002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_scroll.cc:530: EXPECT_EQ(translate,
On 2016/05/17 19:18:51, ajuma wrote:
> On 2016/05/17 18:19:45, sunxd wrote:
> > I'm not sure if there is a better variable to compare here.
> 
> You could compare to the identity (either by comparing to gfx::Transform(), or
> by checking if screen_space_transform.IsIdentity is true).

Done.

[sunxd, 2016-05-17 19:38:05]

The CQ bit was checked by sunxd@chromium.org

[sunxd, 2016-05-17 19:38:05]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1979273002/#ps40001
(title: "Minor change in unit test")

[commit-bot: I haz the power, 2016-05-17 19:38:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979273002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979273002/40001

[commit-bot: I haz the power, 2016-05-17 22:25:22]

Description was changed from

==========
cc: Use to_screen transform for scroll offset snapping

As part of the process of cleaning up transform tree logic, target
space transform is not going to live in the transform tree, so scroll
snapping has to snap screen space transform instead.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use to_screen transform for scroll offset snapping

As part of the process of cleaning up transform tree logic, target
space transform is not going to live in the transform tree, so scroll
snapping has to snap screen space transform instead.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-17 22:25:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-17 22:27:11]

Description was changed from

==========
cc: Use to_screen transform for scroll offset snapping

As part of the process of cleaning up transform tree logic, target
space transform is not going to live in the transform tree, so scroll
snapping has to snap screen space transform instead.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use to_screen transform for scroll offset snapping

As part of the process of cleaning up transform tree logic, target
space transform is not going to live in the transform tree, so scroll
snapping has to snap screen space transform instead.

BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d0d98d0dcf5e3758a604f4c5e61a75166b0e57f7
Cr-Commit-Position: refs/heads/master@{#394245}
==========

[commit-bot: I haz the power, 2016-05-17 22:27:13]

Patchset 3 (id:??) landed as
https://crrev.com/d0d98d0dcf5e3758a604f4c5e61a75166b0e57f7
Cr-Commit-Position: refs/heads/master@{#394245}