Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1979233002: [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. (Closed)

Created:
4 years, 7 months ago by Stefano Sanfilippo
Modified:
4 years, 7 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, mythria
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The bytecode name is passed with --top-dispatches-for-bytecode (short form: -f), while the number of sources and destinations to show is controlled with -n. BUG=v8:4899 LOG=N Committed: https://crrev.com/101e076b34a0b99e9584695109354230819bd1cb Cr-Commit-Position: refs/heads/master@{#36284}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rename flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M tools/ignition/bytecode_dispatches_report.py View 1 4 chunks +41 lines, -3 lines 0 comments Download
M tools/ignition/bytecode_dispatches_report_test.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
Stefano Sanfilippo
4 years, 7 months ago (2016-05-16 15:44:46 UTC) #8
rmcilroy
Nice, LGTM with one suggestion. Thanks. https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode_dispatches_report.py File tools/ignition/bytecode_dispatches_report.py (right): https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode_dispatches_report.py#newcode206 tools/ignition/bytecode_dispatches_report.py:206: "--top-dispatch-sources-destinations-for", "-f", just ...
4 years, 7 months ago (2016-05-17 13:21:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979233002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979233002/100001
4 years, 7 months ago (2016-05-17 13:53:07 UTC) #12
Stefano Sanfilippo
https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode_dispatches_report.py File tools/ignition/bytecode_dispatches_report.py (right): https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode_dispatches_report.py#newcode206 tools/ignition/bytecode_dispatches_report.py:206: "--top-dispatch-sources-destinations-for", "-f", On 2016/05/17 13:21:29, rmcilroy wrote: > just ...
4 years, 7 months ago (2016-05-17 14:05:38 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 14:22:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979233002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979233002/100001
4 years, 7 months ago (2016-05-17 14:41:28 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 7 months ago (2016-05-17 14:42:54 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 14:44:13 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/101e076b34a0b99e9584695109354230819bd1cb
Cr-Commit-Position: refs/heads/master@{#36284}

Powered by Google App Engine
This is Rietveld 408576698