|
|
Created:
4 years, 7 months ago by Stefano Sanfilippo Modified:
4 years, 7 months ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com, mythria Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] List top dispatch sources and destinations for a given Ignition bytecode.
This commit introduces a new mode for bytecode_dispatches_report.py
which reports the top sources of dispatches to a given bytecode and
the top destinations of dispatches from the same bytecode.
The bytecode name is passed with --top-dispatches-for-bytecode
(short form: -f), while the number of sources and destinations to
show is controlled with -n.
BUG=v8:4899
LOG=N
Committed: https://crrev.com/101e076b34a0b99e9584695109354230819bd1cb
Cr-Commit-Position: refs/heads/master@{#36284}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : Rename flag. #
Messages
Total messages: 25 (17 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [Interpreter] List top dispatch sources and destinations for a given bytecode. BUG=v8:4899 LOG=N ========== to ========== ------------------------------------------------------------------------ [Interpreter] List top dispatch sources and destinations for bytecodes. This commit introduces a new mode for bytecode_dispatches_report.py, which reports the top sources of dispatches to a given bytecode, and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form, -f). BUG=v8:4899 LOG=N ==========
Patchset #1 (id:40001) has been deleted
Description was changed from ========== ------------------------------------------------------------------------ [Interpreter] List top dispatch sources and destinations for bytecodes. This commit introduces a new mode for bytecode_dispatches_report.py, which reports the top sources of dispatches to a given bytecode, and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form, -f). BUG=v8:4899 LOG=N ========== to ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py, which reports the top sources of dispatches to a given bytecode, and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form, -f). BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py, which reports the top sources of dispatches to a given bytecode, and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form, -f). BUG=v8:4899 LOG=N ========== to ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py, which reports the top sources of dispatches to a given bytecode, and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form: -f). BUG=v8:4899 LOG=N ==========
ssanfilippo@chromium.org changed reviewers: + rmcilroy@chromium.org
Nice, LGTM with one suggestion. Thanks. https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode... File tools/ignition/bytecode_dispatches_report.py (right): https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode... tools/ignition/bytecode_dispatches_report.py:206: "--top-dispatch-sources-destinations-for", "-f", just --top-dispatches-for-bytecode would be a clearer flag name I think.
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979233002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979233002/100001
Description was changed from ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py, which reports the top sources of dispatches to a given bytecode, and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form: -f). BUG=v8:4899 LOG=N ========== to ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form: -f). BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatch-sources-destinations-for (short form: -f). BUG=v8:4899 LOG=N ========== to ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatches-for-bytecode (short form: -f). BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The number of sources and destinations to show is controlled with -n, while the bytecode name is passed with --top-dispatches-for-bytecode (short form: -f). BUG=v8:4899 LOG=N ========== to ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The bytecode name is passed with --top-dispatches-for-bytecode (short form: -f), while the number of sources and destinations to show is controlled with -n. BUG=v8:4899 LOG=N ==========
https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode... File tools/ignition/bytecode_dispatches_report.py (right): https://codereview.chromium.org/1979233002/diff/60001/tools/ignition/bytecode... tools/ignition/bytecode_dispatches_report.py:206: "--top-dispatch-sources-destinations-for", "-f", On 2016/05/17 13:21:29, rmcilroy wrote: > just --top-dispatches-for-bytecode would be a clearer flag name I think. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ssanfilippo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1979233002/#ps100001 (title: "Rename flag.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979233002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979233002/100001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The bytecode name is passed with --top-dispatches-for-bytecode (short form: -f), while the number of sources and destinations to show is controlled with -n. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The bytecode name is passed with --top-dispatches-for-bytecode (short form: -f), while the number of sources and destinations to show is controlled with -n. BUG=v8:4899 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The bytecode name is passed with --top-dispatches-for-bytecode (short form: -f), while the number of sources and destinations to show is controlled with -n. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] List top dispatch sources and destinations for a given Ignition bytecode. This commit introduces a new mode for bytecode_dispatches_report.py which reports the top sources of dispatches to a given bytecode and the top destinations of dispatches from the same bytecode. The bytecode name is passed with --top-dispatches-for-bytecode (short form: -f), while the number of sources and destinations to show is controlled with -n. BUG=v8:4899 LOG=N Committed: https://crrev.com/101e076b34a0b99e9584695109354230819bd1cb Cr-Commit-Position: refs/heads/master@{#36284} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/101e076b34a0b99e9584695109354230819bd1cb Cr-Commit-Position: refs/heads/master@{#36284} |