Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: components/error_page/common/localized_error.cc

Issue 1979213002: Remove learn more links for SSL_PROTOCOL_ERROR and ERR_SSL_FALLBACK_BEYOND_MINIMUM_VERSION (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/common/localized_error.cc
diff --git a/components/error_page/common/localized_error.cc b/components/error_page/common/localized_error.cc
index dd5fe55c3673bb7baee650fef1d0bdbcec6b33b7..e4af318a73f8205f59292119f481a24274293f2d 100644
--- a/components/error_page/common/localized_error.cc
+++ b/components/error_page/common/localized_error.cc
@@ -48,8 +48,6 @@ static const char kRedirectLoopLearnMoreUrl[] =
"https://support.google.com/chrome?p=rl_error";
static const char kWeakDHKeyLearnMoreUrl[] =
"https://support.google.com/chrome?p=dh_error";
-static const char kSslInvalidResponseLearnMoreUrl[] =
- "https://support.google.com/chrome?p=ir_ssl_error";
static const int kGoogleCachedCopySuggestionType = 0;
enum NAV_SUGGESTIONS {
@@ -267,7 +265,7 @@ const LocalizedErrorMap net_error_options[] = {
IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
IDS_ERRORPAGES_SUMMARY_INVALID_RESPONSE,
IDS_ERRORPAGES_DETAILS_SSL_PROTOCOL_ERROR,
- SUGGEST_RELOAD | SUGGEST_LEARNMORE_STANDALONE,
+ SUGGEST_RELOAD,
},
{net::ERR_BAD_SSL_CLIENT_AUTH_CERT,
IDS_ERRORPAGES_TITLE_LOAD_FAILED,
@@ -330,7 +328,7 @@ const LocalizedErrorMap net_error_options[] = {
IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
IDS_ERRORPAGES_SUMMARY_INVALID_RESPONSE,
IDS_ERRORPAGES_DETAILS_SSL_FALLBACK_BEYOND_MINIMUM_VERSION,
- SUGGEST_LEARNMORE_STANDALONE,
+ SUGGEST_NONE,
},
{net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH,
IDS_ERRORPAGES_TITLE_LOAD_FAILED,
@@ -596,21 +594,11 @@ void AddLinkedSuggestionToList(const int error_code,
suggestion_string = l10n_util::GetStringUTF16(
IDS_ERRORPAGES_SUGGESTION_LEARNMORE_SUMMARY);
break;
- case net::ERR_SSL_FALLBACK_BEYOND_MINIMUM_VERSION:
- learn_more_url = GURL(kSslInvalidResponseLearnMoreUrl);
- suggestion_string = l10n_util::GetStringUTF16(
- IDS_ERRORPAGES_SUGGESTION_LEARNMORE_SUMMARY);
- break;
case net::ERR_TOO_MANY_REDIRECTS:
learn_more_url = GURL(kRedirectLoopLearnMoreUrl);
suggestion_string = l10n_util::GetStringUTF16(
IDS_ERRORPAGES_SUGGESTION_CLEAR_COOKIES_SUMMARY);
break;
- case net::ERR_SSL_PROTOCOL_ERROR:
- learn_more_url = GURL(kSslInvalidResponseLearnMoreUrl);
- suggestion_string = l10n_util::GetStringUTF16(
- IDS_ERRORPAGES_SUGGESTION_LEARNMORE_SUMMARY);
- break;
default:
NOTREACHED();
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698