Recognize Math's min and max function for doubles and inline the operation.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_builder.h"
@@ skipping 2518 matching lines @@
     for (intptr_t i = 0; i < call->ArgumentCount(); ++i) {
       PushArgumentInstr* push = call->PushArgumentAt(i);
       push->ReplaceUsesWith(push->value()->definition());
       push->RemoveFromGraph();
     }
     // Manually replace call with global null constant. ReplaceCall can't
     // be used for definitions that are already in the graph.
     call->ReplaceUsesWith(flow_graph_->constant_null());
     ASSERT(current_iterator()->Current() == call);
     current_iterator()->RemoveCurrentFromGraph();;
+  } else if ((recognized_kind == MethodRecognizer::kMathMin) ||
+             (recognized_kind == MethodRecognizer::kMathMax)) {
+    // We can handle only monomorphic min/max call sites with both arguments
+    // being either doubles or Smi-s
+    if (call->HasICData() && (call->ic_data()->NumberOfChecks() == 1)) {
+      const ICData& ic_data = *call->ic_data();
+      intptr_t result_cid = kIllegalCid;
+      if (ICDataHasReceiverArgumentClassIds(ic_data, kDoubleCid, kDoubleCid)) {
+        result_cid = kDoubleCid;
+      } else if (ICDataHasReceiverArgumentClassIds(ic_data, kSmiCid, kSmiCid)) {
+        // TODO(srdjan): Implement for Smi.
+        result_cid = kIllegalCid;
+      }
+      if (result_cid != kIllegalCid) {
+        MathMinMaxInstr* min_max = new MathMinMaxInstr(
+            recognized_kind,
+            new Value(call->ArgumentAt(0)),
+            new Value(call->ArgumentAt(1)),
+            call->deopt_id(),
+            result_cid);
+        const ICData& unary_checks =
+            ICData::ZoneHandle(ic_data.AsUnaryClassChecks());
+        AddCheckClass(min_max->left()->definition(),
+                      unary_checks,
+                      call->deopt_id(),
+                      call->env(),
+                      call);
+        AddCheckClass(min_max->right()->definition(),
+                      unary_checks,
+                      call->deopt_id(),
+                      call->env(),
+                      call);
+        ReplaceCall(call, min_max);
+      }
+    }
   }
 }
 
 
 bool FlowGraphOptimizer::TryInlineInstanceSetter(InstanceCallInstr* instr,
                                                  const ICData& unary_ic_data) {
   ASSERT((unary_ic_data.NumberOfChecks() > 0) &&
       (unary_ic_data.num_args_tested() == 1));
   if (FLAG_enable_type_checks) {
     // TODO(srdjan): Add assignable check node if --enable_type_checks.
@@ skipping 3725 matching lines @@
   const Object& value = instr->value()->definition()->constant_value();
   if (IsNonConstant(value)) {
     SetValue(instr, non_constant_);
   } else if (IsConstant(value)) {
     // TODO(kmillikin): Handle sqrt.
     SetValue(instr, non_constant_);
   }
 }
 
 
+void ConstantPropagator::VisitMathMinMax(MathMinMaxInstr* instr) {
+  const Object& left = instr->left()->definition()->constant_value();
+  const Object& right = instr->right()->definition()->constant_value();
+  if (IsNonConstant(left) || IsNonConstant(right)) {
+    SetValue(instr, non_constant_);
+  } else if (IsConstant(left) && IsConstant(right)) {
+    // TODO(srdjan): Handle min and max.
+    SetValue(instr, non_constant_);
+  }
+}
+
+
 void ConstantPropagator::VisitUnboxDouble(UnboxDoubleInstr* instr) {
   const Object& value = instr->value()->definition()->constant_value();
   if (IsNonConstant(value)) {
     SetValue(instr, non_constant_);
   } else if (IsConstant(value)) {
     // TODO(kmillikin): Handle conversion.
     SetValue(instr, non_constant_);
   }
 }
 
@@ skipping 901 matching lines @@
 
   // Insert materializations at environment uses.
   const Class& cls = Class::Handle(alloc->constructor().Owner());
   for (intptr_t i = 0; i < exits.length(); i++) {
     CreateMaterializationAt(exits[i], alloc, cls, *fields);
   }
 }
 
 
 }  // namespace dart